* [PATCH] drm/noveau: fix reference count leak in nv50_disp_atomic_commit
@ 2020-06-14 1:29 Aditya Pakki
2020-06-18 15:18 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2020-06-14 1:29 UTC (permalink / raw)
To: pakki001
Cc: kjlu, wu000273, Ben Skeggs, David Airlie, Daniel Vetter,
Lyude Paul, Alex Deucher, Pankaj Bharadiya, Takashi Iwai,
James Jones, dri-devel, nouveau, linux-kernel
nv50_disp_atomic_commit() calls calls pm_runtime_get_sync and in turn
increments the reference count. In case of failure, decrement the
ref count before returning the error.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index d472942102f5..b4039907f0d6 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -2157,8 +2157,10 @@ nv50_disp_atomic_commit(struct drm_device *dev,
int ret, i;
ret = pm_runtime_get_sync(dev->dev);
- if (ret < 0 && ret != -EACCES)
+ if (ret < 0 && ret != -EACCES) {
+ pm_runtime_put_autosuspend(dev->dev);
return ret;
+ }
ret = drm_atomic_helper_setup_commit(state, nonblock);
if (ret)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/noveau: fix reference count leak in nv50_disp_atomic_commit
2020-06-14 1:29 [PATCH] drm/noveau: fix reference count leak in nv50_disp_atomic_commit Aditya Pakki
@ 2020-06-18 15:18 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2020-06-18 15:18 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, wu000273, Ben Skeggs, David Airlie, Daniel Vetter,
Alex Deucher, Pankaj Bharadiya, Takashi Iwai, James Jones,
dri-devel, nouveau, linux-kernel
On Sat, 2020-06-13 at 20:29 -0500, Aditya Pakki wrote:
> nv50_disp_atomic_commit() calls calls pm_runtime_get_sync and in turn
> increments the reference count. In case of failure, decrement the
> ref count before returning the error.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index d472942102f5..b4039907f0d6 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2157,8 +2157,10 @@ nv50_disp_atomic_commit(struct drm_device *dev,
> int ret, i;
>
> ret = pm_runtime_get_sync(dev->dev);
> - if (ret < 0 && ret != -EACCES)
> + if (ret < 0 && ret != -EACCES) {
> + pm_runtime_put_autosuspend(dev->dev);
s/noveau/nouveau/ in the commit title, but other than that:
Reviewed-by: Lyude Paul <lyude@redhat.com>
> return ret;
> + }
>
> ret = drm_atomic_helper_setup_commit(state, nonblock);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-18 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 1:29 [PATCH] drm/noveau: fix reference count leak in nv50_disp_atomic_commit Aditya Pakki
2020-06-18 15:18 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®