[PATCH] drm/amdkfd: enable kfd on RISCV systems

[PATCH] drm/amdkfd: enable kfd on RISCV systems

[liu.song13]

From: Xuemei Liu <liu.xuemei1@zte.com.cn>

KFD has been confirmed that can run on RISCV systems. It's necessary to
support CONFIG_HSA_AMD on RISCV.

Signed-off-by: Xuemei Liu <liu.xuemei1@zte.com.cn>
---
 drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
index d3c3d3ab7225..9d4a5f8ef43f 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -5,7 +5,7 @@

 config HSA_AMD
  bool "HSA kernel driver for AMD GPU devices"
- depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
+ depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64 || RISCV)
  select HMM_MIRROR
  select MMU_NOTIFIER
  select DRM_AMDGPU_USERPTR
-- 
2.25.1

Re: [PATCH] drm/amdkfd: enable kfd on RISCV systems

[Felix Kuehling]

On 2025-04-26 21:25, liu.song13@zte.com.cn wrote:
> From: Xuemei Liu <liu.xuemei1@zte.com.cn>
>
> KFD has been confirmed that can run on RISCV systems. It's necessary to
> support CONFIG_HSA_AMD on RISCV.

Is there a public user mode branch with any changes needed to make ROCm 
user mode work with RISCV?

One more question inline.


> Signed-off-by: Xuemei Liu <liu.xuemei1@zte.com.cn>
> ---
>   drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index d3c3d3ab7225..9d4a5f8ef43f 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -5,7 +5,7 @@
>
>   config HSA_AMD
>    bool "HSA kernel driver for AMD GPU devices"
> - depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
> + depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64 || RISCV)

The KFD memory model only works on 64-bit architectures. Is there a way 
to express that in the RISCV dependency?

Regards,
   Felix


>    select HMM_MIRROR
>    select MMU_NOTIFIER
>    select DRM_AMDGPU_USERPTR

Re: [PATCH] drm/amdkfd: enable kfd on RISCV systems

[liu.song13]

>> From: Xuemei Liu <liu.xuemei1@zte.com.cn>
>>
>> KFD has been confirmed that can run on RISCV systems. It's necessary to
>> support CONFIG_HSA_AMD on RISCV.
> 
> Is there a public user mode branch with any changes needed to make ROCm 
> user mode work with RISCV?
> 
> One more question inline.
> 
> 
>> Signed-off-by: Xuemei Liu <liu.xuemei1@zte.com.cn>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> index d3c3d3ab7225..9d4a5f8ef43f 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> @@ -5,7 +5,7 @@
>>
>>   config HSA_AMD
>>    bool "HSA kernel driver for AMD GPU devices"
>> - depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
>> + depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64 || RISCV)
> 
> The KFD memory model only works on 64-bit architectures. Is there a way 
> to express that in the RISCV dependency?
> 
> Regards,
>   Felix

Dear Felix:

  Thanks for your feedback.
  Regarding the issues you've pointed out:
  1. The adaptation work of ROCm user mode work on RISCV was done by my collegue. He replied that he made no changes in ROCm code.
  2. I will send patch-v2 to satisfy KFD only work on 64-bit architectures.

Best regards,
  Xuemei