From: Michal Simek <michal.simek@xilinx.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org
Cc: Michal Simek <michal.simek@xilinx.com>, kernel@pengutronix.de
Subject: Re: [PATCH] reset: zynqmp: Make reset_control_ops const
Date: Tue, 22 Oct 2019 14:12:59 +0200 [thread overview]
Message-ID: <0b42b11c-d4c4-e7fc-1dc3-c6ac07ab8b1d@xilinx.com> (raw)
In-Reply-To: <20191022115517.19886-1-p.zabel@pengutronix.de>
On 22. 10. 19 13:55, Philipp Zabel wrote:
> The zynqmp_reset_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/reset-zynqmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
> index 99e75d92dada..0144075b11a6 100644
> --- a/drivers/reset/reset-zynqmp.c
> +++ b/drivers/reset/reset-zynqmp.c
> @@ -64,7 +64,7 @@ static int zynqmp_reset_reset(struct reset_controller_dev *rcdev,
> PM_RESET_ACTION_PULSE);
> }
>
> -static struct reset_control_ops zynqmp_reset_ops = {
> +static const struct reset_control_ops zynqmp_reset_ops = {
> .reset = zynqmp_reset_reset,
> .assert = zynqmp_reset_assert,
> .deassert = zynqmp_reset_deassert,
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
prev parent reply other threads:[~2019-10-22 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 11:55 Philipp Zabel
2019-10-22 12:12 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b42b11c-d4c4-e7fc-1dc3-c6ac07ab8b1d@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®