* [PATCH] reset: zynqmp: Make reset_control_ops const
@ 2019-10-22 11:55 Philipp Zabel
2019-10-22 12:12 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2019-10-22 11:55 UTC (permalink / raw)
To: linux-kernel; +Cc: Michal Simek, kernel
The zynqmp_reset_ops structure is never modified. Make it const.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/reset-zynqmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
index 99e75d92dada..0144075b11a6 100644
--- a/drivers/reset/reset-zynqmp.c
+++ b/drivers/reset/reset-zynqmp.c
@@ -64,7 +64,7 @@ static int zynqmp_reset_reset(struct reset_controller_dev *rcdev,
PM_RESET_ACTION_PULSE);
}
-static struct reset_control_ops zynqmp_reset_ops = {
+static const struct reset_control_ops zynqmp_reset_ops = {
.reset = zynqmp_reset_reset,
.assert = zynqmp_reset_assert,
.deassert = zynqmp_reset_deassert,
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] reset: zynqmp: Make reset_control_ops const
2019-10-22 11:55 [PATCH] reset: zynqmp: Make reset_control_ops const Philipp Zabel
@ 2019-10-22 12:12 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2019-10-22 12:12 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel; +Cc: Michal Simek, kernel
On 22. 10. 19 13:55, Philipp Zabel wrote:
> The zynqmp_reset_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/reset-zynqmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
> index 99e75d92dada..0144075b11a6 100644
> --- a/drivers/reset/reset-zynqmp.c
> +++ b/drivers/reset/reset-zynqmp.c
> @@ -64,7 +64,7 @@ static int zynqmp_reset_reset(struct reset_controller_dev *rcdev,
> PM_RESET_ACTION_PULSE);
> }
>
> -static struct reset_control_ops zynqmp_reset_ops = {
> +static const struct reset_control_ops zynqmp_reset_ops = {
> .reset = zynqmp_reset_reset,
> .assert = zynqmp_reset_assert,
> .deassert = zynqmp_reset_deassert,
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-22 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 11:55 [PATCH] reset: zynqmp: Make reset_control_ops const Philipp Zabel
2019-10-22 12:12 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®