From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
agross@kernel.org, konrad.dybcio@somainline.org
Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slimbus: qcom-ngd: Add check for platform_driver_register
Date: Mon, 12 Dec 2022 10:26:11 +0000 [thread overview]
Message-ID: <0b5ca79c-5d8c-5720-cd14-cfa4697b628d@linaro.org> (raw)
In-Reply-To: <20221212094950.23050-1-jiasheng@iscas.ac.cn>
On 12/12/2022 09:49, Jiasheng Jiang wrote:
> Add the check for the return value of platform_driver_register
> in order to catch the exception.
>
> Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Applied thanks,
--srini
> ---
> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
> index 76c5e446d243..c16fc9e6d1c6 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -1590,7 +1590,10 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
> goto err_pdr_lookup;
> }
>
> - platform_driver_register(&qcom_slim_ngd_driver);
> + ret = platform_driver_register(&qcom_slim_ngd_driver);
> + if (ret < 0)
> + goto err_pdr_lookup; > +
> return of_qcom_slim_ngd_register(dev, ctrl);
>
> err_pdr_alloc:
prev parent reply other threads:[~2022-12-12 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 9:49 Jiasheng Jiang
2022-12-12 10:26 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b5ca79c-5d8c-5720-cd14-cfa4697b628d@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jiasheng@iscas.ac.cn \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®