* [PATCH] slimbus: qcom-ngd: Add check for platform_driver_register
@ 2022-12-12 9:49 Jiasheng Jiang
2022-12-12 10:26 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2022-12-12 9:49 UTC (permalink / raw)
To: agross, konrad.dybcio, srinivas.kandagatla
Cc: linux-arm-msm, alsa-devel, linux-kernel, Jiasheng Jiang
Add the check for the return value of platform_driver_register
in order to catch the exception.
Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 76c5e446d243..c16fc9e6d1c6 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1590,7 +1590,10 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
goto err_pdr_lookup;
}
- platform_driver_register(&qcom_slim_ngd_driver);
+ ret = platform_driver_register(&qcom_slim_ngd_driver);
+ if (ret < 0)
+ goto err_pdr_lookup;
+
return of_qcom_slim_ngd_register(dev, ctrl);
err_pdr_alloc:
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] slimbus: qcom-ngd: Add check for platform_driver_register
2022-12-12 9:49 [PATCH] slimbus: qcom-ngd: Add check for platform_driver_register Jiasheng Jiang
@ 2022-12-12 10:26 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2022-12-12 10:26 UTC (permalink / raw)
To: Jiasheng Jiang, agross, konrad.dybcio
Cc: linux-arm-msm, alsa-devel, linux-kernel
On 12/12/2022 09:49, Jiasheng Jiang wrote:
> Add the check for the return value of platform_driver_register
> in order to catch the exception.
>
> Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Applied thanks,
--srini
> ---
> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
> index 76c5e446d243..c16fc9e6d1c6 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -1590,7 +1590,10 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
> goto err_pdr_lookup;
> }
>
> - platform_driver_register(&qcom_slim_ngd_driver);
> + ret = platform_driver_register(&qcom_slim_ngd_driver);
> + if (ret < 0)
> + goto err_pdr_lookup; > +
> return of_qcom_slim_ngd_register(dev, ctrl);
>
> err_pdr_alloc:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-12 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 9:49 [PATCH] slimbus: qcom-ngd: Add check for platform_driver_register Jiasheng Jiang
2022-12-12 10:26 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®