From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Odelu Kukatla <quic_okukatla@quicinc.com>,
Mike Tipton <mdptipton@quicinc.com>,
Vivek Aknurwar <viveka@quicinc.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Sibi Sankar <quic_sibis@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 1/5] interconnect: core: Add dynamic id allocation support
Date: Mon, 20 Jan 2025 11:15:05 +0300 [thread overview]
Message-ID: <0bca7854-aa27-48c6-8612-bcecc7b68c65@stanley.mountain> (raw)
In-Reply-To: <20250111161429.51-2-quic_rlaggysh@quicinc.com>
Hi Raviteja,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Raviteja-Laggyshetty/interconnect-core-Add-dynamic-id-allocation-support/20250112-001756
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250111161429.51-2-quic_rlaggysh%40quicinc.com
patch subject: [PATCH V7 1/5] interconnect: core: Add dynamic id allocation support
config: arm-randconfig-r072-20250118 (https://download.01.org/0day-ci/archive/20250120/202501201530.UTAPd4lC-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project c23f2417dc5f6dc371afb07af5627ec2a9d373a0)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202501201530.UTAPd4lC-lkp@intel.com/
smatch warnings:
drivers/interconnect/core.c:889 icc_node_create_alloc_id() warn: inconsistent returns 'global &icc_lock'.
vim +889 drivers/interconnect/core.c
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 867 struct icc_node *icc_node_create_alloc_id(int start_id)
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 868 {
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 869 struct icc_node *node;
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 870 int id;
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 871
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 872 mutex_lock(&icc_lock);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 873
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 874 node = kzalloc(sizeof(*node), GFP_KERNEL);
Do this allocation before taking the mutex_lock(&icc_lock). Otherwise
you'd have to unlock before returning.
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 875 if (!node)
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 876 return ERR_PTR(-ENOMEM);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 877
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 878 id = idr_alloc(&icc_idr, node, start_id, 0, GFP_KERNEL);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 879 if (id < 0) {
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 880 WARN(1, "%s: couldn't get idr\n", __func__);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 881 kfree(node);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 882 node = ERR_PTR(id);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 883 goto out;
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 884 }
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 885 node->id = id;
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 886 out:
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 887 mutex_unlock(&icc_lock);
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 888
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 @889 return node;
65971f5d716cb8 Raviteja Laggyshetty 2025-01-11 890 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-01-20 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 16:14 [V7 0/5] Add EPSS L3 provider support on SA8775P SoC Raviteja Laggyshetty
2025-01-11 16:14 ` [PATCH V7 1/5] interconnect: core: Add dynamic id allocation support Raviteja Laggyshetty
2025-01-11 20:57 ` Bjorn Andersson
2025-01-23 10:35 ` Raviteja Laggyshetty
2025-01-13 8:14 ` Dmitry Baryshkov
2025-01-23 10:47 ` Raviteja Laggyshetty
2025-01-20 8:15 ` Dan Carpenter [this message]
2025-01-11 16:14 ` [PATCH V7 2/5] interconnect: qcom: Add multidev EPSS L3 support Raviteja Laggyshetty
2025-01-11 21:08 ` Bjorn Andersson
2025-01-23 10:40 ` Raviteja Laggyshetty
2025-01-11 16:14 ` [PATCH V7 3/5] dt-bindings: interconnect: Add EPSS L3 compatible for SA8775P Raviteja Laggyshetty
2025-01-12 9:31 ` Krzysztof Kozlowski
2025-01-23 12:07 ` Raviteja Laggyshetty
2025-01-11 16:14 ` [PATCH V7 4/5] arm64: dts: qcom: sa8775p: add EPSS l3 interconnect provider Raviteja Laggyshetty
2025-01-11 16:14 ` [PATCH V7 5/5] arm64: dts: qcom: sa8775p: Add CPU OPP tables to scale DDR/L3 Raviteja Laggyshetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bca7854-aa27-48c6-8612-bcecc7b68c65@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mdptipton@quicinc.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
--cc=viveka@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®