mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] scsi: ufs: core: Make use of guard(mutex)
Date: Tue, 16 Apr 2024 12:20:05 -0700	[thread overview]
Message-ID: <0beac395-0c89-4fa6-b4a1-d0565373e60a@acm.org> (raw)
In-Reply-To: <20240416102348.614-5-avri.altman@wdc.com>

On 4/16/24 03:23, Avri Altman wrote:
> @@ -5682,9 +5681,8 @@ int ufshcd_write_ee_control(struct ufs_hba *hba)
>   {
>   	int err;
>   
> -	mutex_lock(&hba->ee_ctrl_mutex);
> +	guard(mutex)(&hba->ee_ctrl_mutex);
>   	err = __ufshcd_write_ee_control(hba, hba->ee_ctrl_mask);
> -	mutex_unlock(&hba->ee_ctrl_mutex);
>   	if (err)
>   		dev_err(hba->dev, "%s: failed to write ee control %d\n",
>   			__func__, err);

This change moves the dev_err() statement inside the code block
protected by ee_ctrl_mutex. Please do not make such changes in this
patch.

Thanks,

Bart.

  reply	other threads:[~2024-04-16 19:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 10:23 [PATCH 0/4] simplify ufshcd with the guard() macro Avri Altman
2024-04-16 10:23 ` [PATCH 1/4] scsi: ufs: core: Make use of guard(spinlock_irqsave) Avri Altman
2024-04-16 19:18   ` Bart Van Assche
2024-04-17  6:39     ` Avri Altman
2024-04-16 10:23 ` [PATCH 2/4] scsi: ufs: core: Make use of guard(spinlock) Avri Altman
2024-04-16 10:23 ` [PATCH 3/4] scsi: ufs: core: Make use of guard(spinlock_irq) Avri Altman
2024-04-16 10:23 ` [PATCH 4/4] scsi: ufs: core: Make use of guard(mutex) Avri Altman
2024-04-16 19:20   ` Bart Van Assche [this message]
2024-04-16 19:16 ` [PATCH 0/4] simplify ufshcd with the guard() macro Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0beac395-0c89-4fa6-b4a1-d0565373e60a@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®