mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] scsi: ufs: core: Make use of guard(spinlock_irqsave)
Date: Wed, 17 Apr 2024 06:39:58 +0000	[thread overview]
Message-ID: <DM6PR04MB65751C70ACA41329FF0BC378FC0F2@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <0b031b8f-c07c-42ef-af93-7336439d3c37@acm.org>

> Something I have brought up before: what does the host lock protect in the UFS
> driver? Rather than reworking the code that acquires and releases the host lock,
> all uses of the host lock should be eliminated from the UFS driver. The host lock
> should be replaced with new locks of which it is clearly documented what
> member variables these new locks protect.
Then either this series is pre-mature and needs to be dropped for now,
Or the changes you are planning can take place regardless?

Thanks,
Avri
> 
> Thanks,
> 
> Bart.


  reply	other threads:[~2024-04-17  6:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 10:23 [PATCH 0/4] simplify ufshcd with the guard() macro Avri Altman
2024-04-16 10:23 ` [PATCH 1/4] scsi: ufs: core: Make use of guard(spinlock_irqsave) Avri Altman
2024-04-16 19:18   ` Bart Van Assche
2024-04-17  6:39     ` Avri Altman [this message]
2024-04-16 10:23 ` [PATCH 2/4] scsi: ufs: core: Make use of guard(spinlock) Avri Altman
2024-04-16 10:23 ` [PATCH 3/4] scsi: ufs: core: Make use of guard(spinlock_irq) Avri Altman
2024-04-16 10:23 ` [PATCH 4/4] scsi: ufs: core: Make use of guard(mutex) Avri Altman
2024-04-16 19:20   ` Bart Van Assche
2024-04-16 19:16 ` [PATCH 0/4] simplify ufshcd with the guard() macro Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB65751C70ACA41329FF0BC378FC0F2@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®