From: Filippo Sironi <sironi@amazon.de>
To: Christoph Hellwig <hch@lst.de>
Cc: <serebrin@amazon.com>, <dwmw@amazon.co.uk>, <kbusch@kernel.org>,
<axboe@fb.com>, <sagi@grimberg.me>,
<linux-nvme@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk
Date: Wed, 3 Feb 2021 12:12:31 +0100 [thread overview]
Message-ID: <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> (raw)
In-Reply-To: <20210203095148.GA8897@lst.de>
On 2/3/21 10:51 AM, Christoph Hellwig wrote:
>
> On Wed, Feb 03, 2021 at 10:43:38AM +0100, Filippo Sironi wrote:
>> Certain NVMe controllers don't support 64-bit DMA addresses. Instead,
>> they are limited to 48-bit DMA addresses. Let's add a quirk to use them
>> properly.
>
> WTF? This is such a grave NVMe spec compiance bug that I do not think
> we should support this buggy mess in Linux.
>
I don't disagree on the first part of your sentence, this is a big
oversight.
On the other hand, those controllers are out there and are in use by a
lot of customers. We can keep relying on luck, hoping that customers
don't run into troubles or we can merge a few lines of code :)
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2021-02-03 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 9:43 Filippo Sironi
2021-02-03 9:51 ` Christoph Hellwig
2021-02-03 11:12 ` Filippo Sironi [this message]
2021-02-03 11:15 ` Christoph Hellwig
2021-02-03 11:22 ` Filippo Sironi
2021-02-03 11:26 ` Christoph Hellwig
2021-02-03 16:57 ` Keith Busch
2021-02-10 0:39 ` [PATCH v2] nvme: Add 48-bit DMA address quirk for Amazon NVMe controllers Filippo Sironi
2021-02-10 7:37 ` Christoph Hellwig
2021-02-10 9:13 ` Filippo Sironi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de \
--to=sironi@amazon.de \
--cc=axboe@fb.com \
--cc=dwmw@amazon.co.uk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=serebrin@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®