* [PATCH] tty: serial: fsl_lpuart: remove the count initialization as it is not needed
@ 2022-04-18 2:18 Sherry Sun
2022-04-19 7:55 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Sherry Sun @ 2022-04-18 2:18 UTC (permalink / raw)
To: gregkh, jirislaby; +Cc: linux-serial, linux-kernel, linux-imx
No need to initialize the count variable in lpuart_copy_rx_to_tty(),
so let's remove it here.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
drivers/tty/serial/fsl_lpuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 87789872f400..452a015825ba 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1118,7 +1118,7 @@ static void lpuart_copy_rx_to_tty(struct lpuart_port *sport)
struct dma_chan *chan = sport->dma_rx_chan;
struct circ_buf *ring = &sport->rx_ring;
unsigned long flags;
- int count = 0, copied;
+ int count, copied;
if (lpuart_is_32(sport)) {
unsigned long sr = lpuart32_read(&sport->port, UARTSTAT);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] tty: serial: fsl_lpuart: remove the count initialization as it is not needed
2022-04-18 2:18 [PATCH] tty: serial: fsl_lpuart: remove the count initialization as it is not needed Sherry Sun
@ 2022-04-19 7:55 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2022-04-19 7:55 UTC (permalink / raw)
To: Sherry Sun, gregkh; +Cc: linux-serial, linux-kernel, linux-imx
On 18. 04. 22, 4:18, Sherry Sun wrote:
> No need to initialize the count variable in lpuart_copy_rx_to_tty(),
> so let's remove it here.
Right,
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 87789872f400..452a015825ba 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1118,7 +1118,7 @@ static void lpuart_copy_rx_to_tty(struct lpuart_port *sport)
> struct dma_chan *chan = sport->dma_rx_chan;
> struct circ_buf *ring = &sport->rx_ring;
> unsigned long flags;
> - int count = 0, copied;
> + int count, copied;
>
> if (lpuart_is_32(sport)) {
> unsigned long sr = lpuart32_read(&sport->port, UARTSTAT);
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-19 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 2:18 [PATCH] tty: serial: fsl_lpuart: remove the count initialization as it is not needed Sherry Sun
2022-04-19 7:55 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®