* [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0
@ 2012-11-19 4:56 Sachin Kamat
2012-11-20 11:49 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2012-11-19 4:56 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, kgene.kim, sachin.kamat, patches
Static variables are initialised to 0 by GCC.
Fixes the following checkpatch error:
ERROR: do not initialise statics to 0 or NULL
FILE: pinctrl/pinctrl-samsung.c:50:
static unsigned int pin_base = 0;
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-samsung.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 81c9896..36f8875 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -47,7 +47,7 @@ struct pin_config {
{ "samsung,pin-pud-pdn", PINCFG_TYPE_PUD_PDN },
};
-static unsigned int pin_base = 0;
+static unsigned int pin_base;
static inline struct samsung_pin_bank *gc_to_pin_bank(struct gpio_chip *gc)
{
--
1.7.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0
2012-11-19 4:56 [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0 Sachin Kamat
@ 2012-11-20 11:49 ` Kukjin Kim
2012-11-23 7:36 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2012-11-20 11:49 UTC (permalink / raw)
To: 'Sachin Kamat', linux-kernel; +Cc: linus.walleij, patches
Sachin Kamat wrote:
>
> Static variables are initialised to 0 by GCC.
> Fixes the following checkpatch error:
> ERROR: do not initialise statics to 0 or NULL
> FILE: pinctrl/pinctrl-samsung.c:50:
> static unsigned int pin_base = 0;
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/pinctrl/pinctrl-samsung.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-
> samsung.c
> index 81c9896..36f8875 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -47,7 +47,7 @@ struct pin_config {
> { "samsung,pin-pud-pdn", PINCFG_TYPE_PUD_PDN },
> };
>
> -static unsigned int pin_base = 0;
> +static unsigned int pin_base;
>
> static inline struct samsung_pin_bank *gc_to_pin_bank(struct gpio_chip
> *gc)
> {
> --
> 1.7.4.1
Looks OK to me.
Linus, can I pick this up in my tree?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0
2012-11-20 11:49 ` Kukjin Kim
@ 2012-11-23 7:36 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2012-11-23 7:36 UTC (permalink / raw)
To: Kukjin Kim; +Cc: Sachin Kamat, linux-kernel, patches
On Tue, Nov 20, 2012 at 12:49 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> Static variables are initialised to 0 by GCC.
>> Fixes the following checkpatch error:
>> ERROR: do not initialise statics to 0 or NULL
>> FILE: pinctrl/pinctrl-samsung.c:50:
>> static unsigned int pin_base = 0;
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> (...)
>
> Looks OK to me.
>
> Linus, can I pick this up in my tree?
Yes, go ahead:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-23 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-19 4:56 [PATCH 1/1] pinctrl: Samsung: Do not initialise statics to 0 Sachin Kamat
2012-11-20 11:49 ` Kukjin Kim
2012-11-23 7:36 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®