mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: Steve Sistare <steven.sistare@oracle.com>,
	Daniel Jordan <daniel.m.jordan@oracle.com>,
	<linux@armlinux.org.uk>, <schwidefsky@de.ibm.com>,
	<heiko.carstens@de.ibm.com>, John Stultz <john.stultz@linaro.org>,
	<sboyd@codeaurora.org>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, <hpa@zytor.com>
Subject: Re: [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock
Date: Wed, 15 Nov 2017 10:47:45 +0800	[thread overview]
Message-ID: <0c9ba6e2-d9a7-f792-9e4b-acea4eb2bb7a@cn.fujitsu.com> (raw)
In-Reply-To: <CAOAebxvhsyR8-qbT63pkSkpHtCsbHDktnA=t_QzfSrdmN0ydjQ@mail.gmail.com>

Hi Pavel,

At 11/15/2017 03:57 AM, Pavel Tatashin wrote:
>> why we should remove the *extern* keyword?
>
> Hi Dou,
>
> While, I am not sure why it was decided to stop using externs in
> headers, this is a warning printed by scripts/checkpatch.pl:
>
> CHECK: extern prototypes should be avoided in .h files
>
> To have a clean checkpatch output I removed externs.
>

I see.

IMO, using the extern keyword on function prototypes in *.h files
is superfluous, but, It doesn't matter for functionality. *extern*
is default keywords.

AFAIK, it's a code style problem. In x86 arch, we prefer to
keep *extern* explicitly, so, let's keep it like before for
code consistency.

Thank,
	dou

  reply	other threads:[~2017-11-15  2:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  3:01 [PATCH v8 0/6] Early boot time stamps for x86 Pavel Tatashin
2017-11-09  3:01 ` [PATCH v8 1/6] x86/tsc: remove tsc_disabled flag Pavel Tatashin
2017-11-13  3:52   ` Dou Liyang
2017-11-13 18:51     ` Pavel Tatashin
2017-11-09  3:01 ` [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock Pavel Tatashin
2017-11-13  3:47   ` Dou Liyang
2017-11-14 19:57     ` Pavel Tatashin
2017-11-15  2:47       ` Dou Liyang [this message]
2017-11-15  3:56         ` Pavel Tatashin
2017-11-09  3:01 ` [PATCH v8 3/6] x86/time: read_boot_clock64() implementation Pavel Tatashin
2017-11-09  3:01 ` [PATCH v8 4/6] sched: early boot clock Pavel Tatashin
2017-11-09  3:02 ` [PATCH v8 5/6] x86/paravirt: add active_sched_clock to pv_time_ops Pavel Tatashin
2017-11-09  3:02 ` [PATCH v8 6/6] x86/tsc: use tsc early Pavel Tatashin
2017-11-13  3:47   ` Dou Liyang
2017-11-14 21:46     ` Pavel Tatashin
2017-11-15  3:53       ` Dou Liyang
2017-11-15 16:01         ` Pavel Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c9ba6e2-d9a7-f792-9e4b-acea4eb2bb7a@cn.fujitsu.com \
    --to=douly.fnst@cn.fujitsu.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=pasha.tatashin@oracle.com \
    --cc=sboyd@codeaurora.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=steven.sistare@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®