* [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()
@ 2018-01-13 9:34 SF Markus Elfring
2018-01-17 18:03 ` Santosh Shilimkar
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2018-01-13 9:34 UTC (permalink / raw)
To: kernel-janitors, Santosh Shilimkar; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 13 Jan 2018 10:24:03 +0100
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/memory/emif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 04644e7b42b1..2f214440008c 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -127,7 +127,7 @@ static int emif_regdump_show(struct seq_file *s, void *unused)
for (i = 0; i < EMIF_MAX_NUM_FREQUENCIES && regs_cache[i]; i++) {
do_emif_regdump_show(s, emif, regs_cache[i]);
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}
return 0;
--
2.15.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()
2018-01-13 9:34 [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show() SF Markus Elfring
@ 2018-01-17 18:03 ` Santosh Shilimkar
0 siblings, 0 replies; 2+ messages in thread
From: Santosh Shilimkar @ 2018-01-17 18:03 UTC (permalink / raw)
To: SF Markus Elfring, kernel-janitors, Santosh Shilimkar; +Cc: LKML
On 1/13/2018 1:34 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 13 Jan 2018 10:24:03 +0100
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Looks fine. Will pick it up for next merge window.
Regards,
Santosh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-17 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-13 9:34 [PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show() SF Markus Elfring
2018-01-17 18:03 ` Santosh Shilimkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®