mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: Chu Guangqing <chuguangqing@inspur.com>
Cc: john.g.garry@oracle.com, will@kernel.org, james.clark@linaro.org,
	 mike.leach@linaro.org, leo.yan@linux.dev, peterz@infradead.org,
	 mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
	 mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org,  irogers@google.com, adrian.hunter@intel.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/perf: Fix spelling typo in tools/perf
Date: Fri, 31 Oct 2025 12:17:01 -0700 (PDT)	[thread overview]
Message-ID: <0cc4d296-dd2f-5a07-59bd-d9cecc73d28c@os.amperecomputing.com> (raw)
In-Reply-To: <20251031025810.1939-1-chuguangqing@inspur.com>


On Fri, 31 Oct 2025, Chu Guangqing wrote:
> The json file incorrectly used "acceses" instead of "accesses".
>
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>

Thanks for the patch! I have just one comment, would you mind changing the 
subject line to match to the patches touching those event json files? 
Something like this

"perf vendor events arm64 AmpereOneX: Fix spelling typo in the metrics 
file"


With that change

Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>

Cheers, Ilkka


> ---
> .../arch/arm64/ampere/ampereonex/metrics.json    | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json
> index 6817cac149e0..a29aadc9b2e3 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json
> @@ -388,55 +388,55 @@
>         "MetricExpr": "L1D_CACHE_RW / L1D_CACHE",
>         "BriefDescription": "L1D cache access - demand",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_access_prefetches",
>         "MetricExpr": "L1D_CACHE_PRFM / L1D_CACHE",
>         "BriefDescription": "L1D cache access - prefetch",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_demand_misses",
>         "MetricExpr": "L1D_CACHE_REFILL_RW / L1D_CACHE",
>         "BriefDescription": "L1D cache demand misses",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_demand_misses_read",
>         "MetricExpr": "L1D_CACHE_REFILL_RD / L1D_CACHE",
>         "BriefDescription": "L1D cache demand misses - read",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_demand_misses_write",
>         "MetricExpr": "L1D_CACHE_REFILL_WR / L1D_CACHE",
>         "BriefDescription": "L1D cache demand misses - write",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_prefetch_misses",
>         "MetricExpr": "L1D_CACHE_REFILL_PRFM / L1D_CACHE",
>         "BriefDescription": "L1D cache prefetch misses",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "ase_scalar_mix",
>         "MetricExpr": "ASE_SCALAR_SPEC / OP_SPEC",
>         "BriefDescription": "Proportion of advanced SIMD data processing operations (excluding DP_SPEC/LD_SPEC) scalar operations",
>         "MetricGroup": "Instructions",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "ase_vector_mix",
>         "MetricExpr": "ASE_VECTOR_SPEC / OP_SPEC",
>         "BriefDescription": "Proportion of advanced SIMD data processing operations (excluding DP_SPEC/LD_SPEC) vector operations",
>         "MetricGroup": "Instructions",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     }
> ]
> -- 
> 2.43.7
>
>
>

  parent reply	other threads:[~2025-10-31 19:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  2:58 Chu Guangqing
2025-10-31 10:01 ` James Clark
2025-10-31 19:17 ` Ilkka Koskinen [this message]
2025-11-03 17:53 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cc4d296-dd2f-5a07-59bd-d9cecc73d28c@os.amperecomputing.com \
    --to=ilkka@os.amperecomputing.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=chuguangqing@inspur.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®