From: Paolo Abeni <pabeni@redhat.com>
To: Li kunyu <kunyu@nfschina.com>,
rajur@chelsio.com, edumazet@google.com, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: Remove extra commas and align them
Date: Thu, 30 Jun 2022 12:58:56 +0200 [thread overview]
Message-ID: <0cddb061e2b863c9f4a652e923d0b689ec7ecd30.camel@redhat.com> (raw)
In-Reply-To: <20220629083530.48186-1-kunyu@nfschina.com>
On Wed, 2022-06-29 at 16:35 +0800, Li kunyu wrote:
> There is an extra comma and space in this sentence when I read the code.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
Sorry, I'm going to be quite nitpicking on this kind of patches. Please
try to stick to a consistent format, see Jakub guidance:
https://lore.kernel.org/all/20220623092208.1abbd9dc@kernel.org/
e.g.
<sub-system>: fix typo in <somewhere>
Remove the repeated <what> from <somewhere>
Thanks!
Paolo
prev parent reply other threads:[~2022-06-30 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 8:35 Li kunyu
2022-06-30 10:58 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cddb061e2b863c9f4a652e923d0b689ec7ecd30.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kunyu@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®