* [PATCH] drivers: Remove extra commas and align them
@ 2022-06-29 8:35 Li kunyu
2022-06-30 10:58 ` Paolo Abeni
0 siblings, 1 reply; 2+ messages in thread
From: Li kunyu @ 2022-06-29 8:35 UTC (permalink / raw)
To: rajur, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel, Li kunyu
There is an extra comma and space in this sentence when I read the code.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
index 4a872f328fea..7d5204834ee2 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
@@ -85,7 +85,7 @@ static void cxgb4_dcb_cleanup_apps(struct net_device *dev)
if (err) {
dev_err(adap->pdev_dev,
- "Failed DCB Clear %s Application Priority: sel=%d, prot=%d, , err=%d\n",
+ "Failed DCB Clear %s Application Priority: sel=%d, prot=%d, err=%d\n",
dcb_ver_array[dcb->dcb_version], app.selector,
app.protocol, -err);
break;
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: Remove extra commas and align them
2022-06-29 8:35 [PATCH] drivers: Remove extra commas and align them Li kunyu
@ 2022-06-30 10:58 ` Paolo Abeni
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2022-06-30 10:58 UTC (permalink / raw)
To: Li kunyu, rajur, edumazet, kuba; +Cc: netdev, linux-kernel
On Wed, 2022-06-29 at 16:35 +0800, Li kunyu wrote:
> There is an extra comma and space in this sentence when I read the code.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
Sorry, I'm going to be quite nitpicking on this kind of patches. Please
try to stick to a consistent format, see Jakub guidance:
https://lore.kernel.org/all/20220623092208.1abbd9dc@kernel.org/
e.g.
<sub-system>: fix typo in <somewhere>
Remove the repeated <what> from <somewhere>
Thanks!
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-30 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 8:35 [PATCH] drivers: Remove extra commas and align them Li kunyu
2022-06-30 10:58 ` Paolo Abeni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®