mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "T, Pratham" <t-pratham@ti.com>
To: "Chawdhry, Manorit" <m-chawdhry@ti.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"J, KEERTHY" <j-keerthy@ti.com>,
	Colin Ian King <colin.i.king@gmail.com>
Cc: "Davis, Andrew" <afd@ti.com>,
	"Gurudasani, Kamlesh" <kamlesh@ti.com>,
	"Kumar, Udit" <u-kumar1@ti.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 20/30] crypto: sa2ul - handle transform initialization failures
Date: Wed, 18 Nov 2026 09:26:02 +0000	[thread overview]
Message-ID: <0ce0ffdb-d86d-4d3a-842b-e960ddf19a9c@ti.com> (raw)
In-Reply-To: <20261104-b4-upstream-sa2ul-cleanup-v2-20-15ab90b3f9c2@ti.com>

On 04/11/2026 11:14, Chawdhry, Manorit wrote:
> Stop initialization when security-context or fallback allocation fails,
> and propagate hash setup errors instead of exposing a partial transform.
> 
> Unwind acquired fallback transforms and security contexts in reverse
> order. Release the hash context on fallback allocation failure, and use
> the hash teardown path when command-label setup fails.
> 
> Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
> Fixes: 2dc53d004745 ("crypto: sa2ul - add sha1/sha256/sha512 support")
> Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support")
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---

[...]

> @@ -1407,7 +1410,9 @@ static int sa_sha_cra_init_alg(struct crypto_tfm *tfm, const char *alg_base)
>  		if (IS_ERR(ctx->fallback.ahash)) {
>  			dev_err(ctx->dev_data->dev,
>  				"Could not load fallback driver\n");
> -			return PTR_ERR(ctx->fallback.ahash);
> +			ret = PTR_ERR(ctx->fallback.ahash);
> +			ctx->fallback.ahash = NULL;
> +			goto err_free_ctx;
>  		}
>  	}
>  
> @@ -1420,8 +1425,14 @@ static int sa_sha_cra_init_alg(struct crypto_tfm *tfm, const char *alg_base)
>  				 crypto_ahash_reqsize(ctx->fallback.ahash));
>  
>  	return 0;
> +
> +err_free_ctx:
> +	sa_free_ctx_info(&ctx->enc, data);
> +	return ret;
>  }
>  
> +static void sa_sha_cra_exit(struct crypto_tfm *tfm);
> +

The function definition can be moved here instead of a forward declaration.

-- 
Regards
T Pratham <t-pratham@ti.com>

  reply	other threads:[~2026-11-18  9:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  5:44 [PATCH v2 00/30] Clean and improve SA2UL driver Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 01/30] crypto: sa2ul - remove dead code Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 02/30] crypto: sa2ul - remove totally unused structure fields Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 03/30] crypto: sa2ul - remove unused fields from sa_cmdl_cfg Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 04/30] crypto: sa2ul - remove unused context fields Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 05/30] crypto: sa2ul - remove unused macro definitions Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 06/30] crypto: sa2ul - remove unused base register pointer Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 07/30] crypto: sa2ul - remove unused includes and defines Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 08/30] crypto: sa2ul - remove unused line Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 09/30] crypto: sa2ul - remove redundant sa_sha_digest() wrapper Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 10/30] crypto: sa2ul - fix struct documentation for match_data Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 11/30] crypto: sa2ul - keep the probe register mapping local Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 12/30] crypto: sa2ul - zero out security context on free Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 13/30] crypto: sa2ul - preserve full authentication key lengths Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 14/30] crypto: sa2ul - validate AES key sizes before indexing Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 15/30] crypto: sa2ul - remove unused SC ID range tracking Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 16/30] crypto: sa2ul - copy command-label inputs locally Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 17/30] crypto: sa2ul - consolidate encryption offset definitions Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 18/30] crypto: sa2ul - handle unaligned IV buffers Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 19/30] crypto: sa2ul - remove redundant algorithm ID fields Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 20/30] crypto: sa2ul - handle transform initialization failures Manorit Chawdhry
2026-11-18  9:26   ` T, Pratham [this message]
2026-11-04  5:44 ` [PATCH v2 21/30] crypto: sa2ul - reject exhausted context IDs Manorit Chawdhry
2026-11-04 13:31   ` Thorsten Blum
2026-11-04  5:44 ` [PATCH v2 22/30] crypto: sa2ul - validate scatterlist setup and unwind DMA mappings Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 23/30] crypto: sa2ul - propagate DMA transfer errors Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 24/30] crypto: sa2ul - calculate DMA metadata length from the command label Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 25/30] crypto: sa2ul - correct scatterlist DMA ownership transitions Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 26/30] crypto: sa2ul - use a mempool for security contexts Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 27/30] crypto: sa2ul - use synchronous fallbacks and fixed request sizes Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 28/30] crypto: sa2ul - route requests through crypto_engine Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 29/30] crypto: sa2ul - report SA engine hardware revision Manorit Chawdhry
2026-11-04  5:44 ` [PATCH v2 30/30] crypto: sa2ul - add SA3UL_CM AES support Manorit Chawdhry
2026-11-13 13:09 ` [PATCH v2 00/30] Clean and improve SA2UL driver Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ce0ffdb-d86d-4d3a-842b-e960ddf19a9c@ti.com \
    --to=t-pratham@ti.com \
    --cc=afd@ti.com \
    --cc=colin.i.king@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=j-keerthy@ti.com \
    --cc=kamlesh@ti.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®