From: Herbert Xu <herbert@gondor.apana.org.au>
To: Manorit Chawdhry <m-chawdhry@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Keerthy <j-keerthy@ti.com>,
Colin Ian King <colin.i.king@gmail.com>,
Andrew Davis <afd@ti.com>, Pratham T <t-pratham@ti.com>,
Kamlesh Gurudasani <kamlesh@ti.com>, Udit Kumar <u-kumar1@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/30] Clean and improve SA2UL driver
Date: Fri, 13 Nov 2026 21:09:18 +0800 [thread overview]
Message-ID: <avcL_qGCSs4dA_zJ@gondor.apana.org.au> (raw)
In-Reply-To: <20261104-b4-upstream-sa2ul-cleanup-v2-0-15ab90b3f9c2@ti.com>
On Wed, Nov 04, 2026 at 11:14:10AM +0530, Manorit Chawdhry wrote:
> The following series focuses on some cleanups to the sa2ul driver, it
> starts with very trivial cleanups then goes to fix some bigger cleanups
> and migration to crypto_engine which help fix the broader race condition
> problems with the driver, thereafter it adds the support for AES CM as
> per SAxUL 3.1 IP. KASAN is also run alongside to fix the issues caught
> by them.
>
> https://gist.github.com/manorit2001/0c005603f1a2da0e82c760e209ab0c4a
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
> Changes in v2:
>
> * Sashiko (visible web review)
> - Improve some commit descriptions
> - Map contexts at allocation and remove the redundant mempool
> allocation check
> - Prime AES-CM before registering algorithms; fail probe if
> priming fails
> - Wipe the temporary AES-CM round key
>
> * Sashiko (API-only concerns) [0]
> - Make the probe register mapping local
> - Validate context IDs and AES keys
> - Check scatterlist errors and handle unaligned IVs
> - Synchronize DMA using the recorded mapping direction
>
> * Pratham
> - Use fixed hash/skcipher request sizes
> - Migrate to init_tfm/exit_tfm
>
> * Self
> - Rebase onto linux-next
> - Remove Assisted-by tags
> - Drop few patches that are irrelevant after rebase
> - Remove redundant algorithm IDs while preserving digest sizes
>
> - Remove unused SA_MAX_AUX_DATA_WORDS
> - Preserve full authentication-key lengths
> - Propagate DMA completion errors in a separate fix
> - Unwind fallback transforms and security contexts on init failure
> - Stop the engine and quiesce DMA once before teardown
>
> Link to v1: https://lore.kernel.org/all/20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com
>
> [0] https://sashiko.dev/api/patchset?id=20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162%40ti.com
>
> ---
> Manorit Chawdhry (30):
> crypto: sa2ul - remove dead code
> crypto: sa2ul - remove totally unused structure fields
> crypto: sa2ul - remove unused fields from sa_cmdl_cfg
> crypto: sa2ul - remove unused context fields
> crypto: sa2ul - remove unused macro definitions
> crypto: sa2ul - remove unused base register pointer
> crypto: sa2ul - remove unused includes and defines
> crypto: sa2ul - remove unused line
> crypto: sa2ul - remove redundant sa_sha_digest() wrapper
> crypto: sa2ul - fix struct documentation for match_data
> crypto: sa2ul - keep the probe register mapping local
> crypto: sa2ul - zero out security context on free
> crypto: sa2ul - preserve full authentication key lengths
> crypto: sa2ul - validate AES key sizes before indexing
> crypto: sa2ul - remove unused SC ID range tracking
> crypto: sa2ul - copy command-label inputs locally
> crypto: sa2ul - consolidate encryption offset definitions
> crypto: sa2ul - handle unaligned IV buffers
> crypto: sa2ul - remove redundant algorithm ID fields
> crypto: sa2ul - handle transform initialization failures
> crypto: sa2ul - reject exhausted context IDs
> crypto: sa2ul - validate scatterlist setup and unwind DMA mappings
> crypto: sa2ul - propagate DMA transfer errors
> crypto: sa2ul - calculate DMA metadata length from the command label
> crypto: sa2ul - correct scatterlist DMA ownership transitions
> crypto: sa2ul - use a mempool for security contexts
> crypto: sa2ul - use synchronous fallbacks and fixed request sizes
> crypto: sa2ul - route requests through crypto_engine
> crypto: sa2ul - report SA engine hardware revision
> crypto: sa2ul - add SA3UL_CM AES support
>
> drivers/crypto/Kconfig | 1 +
> drivers/crypto/sa2ul.c | 1265 +++++++++++++++++++++++++++++++-----------------
> drivers/crypto/sa2ul.h | 172 ++-----
> 3 files changed, 854 insertions(+), 584 deletions(-)
> ---
> base-commit: 7649ba73f9e7e1e04d0b46213e39c79ae09dd55c
> change-id: 20251106-b4-upstream-sa2ul-cleanup-ce85d40c7eb8
>
> Best regards,
> --
> Manorit Chawdhry <m-chawdhry@ti.com>
Patches 1-6 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-11-13 13:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 5:44 Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 01/30] crypto: sa2ul - remove dead code Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 02/30] crypto: sa2ul - remove totally unused structure fields Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 03/30] crypto: sa2ul - remove unused fields from sa_cmdl_cfg Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 04/30] crypto: sa2ul - remove unused context fields Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 05/30] crypto: sa2ul - remove unused macro definitions Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 06/30] crypto: sa2ul - remove unused base register pointer Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 07/30] crypto: sa2ul - remove unused includes and defines Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 08/30] crypto: sa2ul - remove unused line Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 09/30] crypto: sa2ul - remove redundant sa_sha_digest() wrapper Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 10/30] crypto: sa2ul - fix struct documentation for match_data Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 11/30] crypto: sa2ul - keep the probe register mapping local Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 12/30] crypto: sa2ul - zero out security context on free Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 13/30] crypto: sa2ul - preserve full authentication key lengths Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 14/30] crypto: sa2ul - validate AES key sizes before indexing Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 15/30] crypto: sa2ul - remove unused SC ID range tracking Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 16/30] crypto: sa2ul - copy command-label inputs locally Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 17/30] crypto: sa2ul - consolidate encryption offset definitions Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 18/30] crypto: sa2ul - handle unaligned IV buffers Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 19/30] crypto: sa2ul - remove redundant algorithm ID fields Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 20/30] crypto: sa2ul - handle transform initialization failures Manorit Chawdhry
2026-11-18 9:26 ` T, Pratham
2026-11-04 5:44 ` [PATCH v2 21/30] crypto: sa2ul - reject exhausted context IDs Manorit Chawdhry
2026-11-04 13:31 ` Thorsten Blum
2026-11-04 5:44 ` [PATCH v2 22/30] crypto: sa2ul - validate scatterlist setup and unwind DMA mappings Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 23/30] crypto: sa2ul - propagate DMA transfer errors Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 24/30] crypto: sa2ul - calculate DMA metadata length from the command label Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 25/30] crypto: sa2ul - correct scatterlist DMA ownership transitions Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 26/30] crypto: sa2ul - use a mempool for security contexts Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 27/30] crypto: sa2ul - use synchronous fallbacks and fixed request sizes Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 28/30] crypto: sa2ul - route requests through crypto_engine Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 29/30] crypto: sa2ul - report SA engine hardware revision Manorit Chawdhry
2026-11-04 5:44 ` [PATCH v2 30/30] crypto: sa2ul - add SA3UL_CM AES support Manorit Chawdhry
2026-11-13 13:09 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avcL_qGCSs4dA_zJ@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=afd@ti.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=j-keerthy@ti.com \
--cc=kamlesh@ti.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=t-pratham@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®