mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] virt: vbox: Remove unproper information
Date: Thu, 1 Sep 2022 16:49:05 +0200	[thread overview]
Message-ID: <0cf9b1f8-96c5-3d4d-d922-96dc1ef69d10@redhat.com> (raw)
In-Reply-To: <20220901144619.3550352-1-jiasheng@iscas.ac.cn>

Hi,

On 9/1/22 16:46, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the vbg_info() should be removed.
> 
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/virt/vboxguest/vboxguest_linux.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 6fc81347ae72..c47e62dc55da 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>  
>  	pci_set_drvdata(pci, gdev);
>  
> -	vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
> -		 gdev->misc_device.minor, pci->irq, gdev->io_port,
> -		 &mmio, &mmio_len);
> -
>  	return 0;
>  
>  err_unregister_misc_device_user:


      reply	other threads:[~2022-09-01 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 14:46 Jiasheng Jiang
2022-09-01 14:49 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cf9b1f8-96c5-3d4d-d922-96dc1ef69d10@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiasheng@iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®