* [PATCH v3 2/2] virt: vbox: Remove unproper information
@ 2022-09-01 14:46 Jiasheng Jiang
2022-09-01 14:49 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2022-09-01 14:46 UTC (permalink / raw)
To: gregkh; +Cc: hdegoede, arnd, linux-kernel, Jiasheng Jiang
When drivers are working properly, they are quiet.
Therefore, the vbg_info() should be removed.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/virt/vboxguest/vboxguest_linux.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
index 6fc81347ae72..c47e62dc55da 100644
--- a/drivers/virt/vboxguest/vboxguest_linux.c
+++ b/drivers/virt/vboxguest/vboxguest_linux.c
@@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
pci_set_drvdata(pci, gdev);
- vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
- gdev->misc_device.minor, pci->irq, gdev->io_port,
- &mmio, &mmio_len);
-
return 0;
err_unregister_misc_device_user:
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v3 2/2] virt: vbox: Remove unproper information
2022-09-01 14:46 [PATCH v3 2/2] virt: vbox: Remove unproper information Jiasheng Jiang
@ 2022-09-01 14:49 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-09-01 14:49 UTC (permalink / raw)
To: Jiasheng Jiang, gregkh; +Cc: arnd, linux-kernel
Hi,
On 9/1/22 16:46, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the vbg_info() should be removed.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/virt/vboxguest/vboxguest_linux.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 6fc81347ae72..c47e62dc55da 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -398,10 +398,6 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>
> pci_set_drvdata(pci, gdev);
>
> - vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
> - gdev->misc_device.minor, pci->irq, gdev->io_port,
> - &mmio, &mmio_len);
> -
> return 0;
>
> err_unregister_misc_device_user:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-01 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 14:46 [PATCH v3 2/2] virt: vbox: Remove unproper information Jiasheng Jiang
2022-09-01 14:49 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®