From: Andrew Lunn <andrew@lunn.ch>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net: phy: honor eee_disabled_modes in phy_support_eee()
Date: Tue, 19 May 2026 13:56:23 +0200 [thread overview]
Message-ID: <0d11744b-e235-437d-b14d-3b49e0e162ef@lunn.ch> (raw)
In-Reply-To: <7245b9c6294300265636ad954c01c248@tipi-net.de>
On Tue, May 19, 2026 at 08:20:02AM +0200, Nicolai Buchwitz wrote:
> Hi Andrew,
>
> Thanks for your review.
>
> On 19.5.2026 04:19, Andrew Lunn wrote:
> > On Mon, May 18, 2026 at 10:23:09AM +0200, Nicolai Buchwitz wrote:
> > > phy_support_eee() copies supported_eee into advertising_eee
> > > unconditionally, overwriting any filtering applied during phy_probe()
> > > based on DT eee-broken-* properties or driver-populated
> > > eee_disabled_modes.
> >
> > Sorry, i should of questioned this on v1. What PHY are you using which
> > masks advertising_eee in probe? It seems like this is wrong, and it
> > should be setting >eee_disabled_modes, or maybe eee_supported.c
>
> The masking isn't PHY-specific. phy_probe() applies eee_disabled_modes
> to advertising_eee after of_set_phy_eee_broken() picks up the
> eee-broken-* properties from the PHY DT node.
Ah, O.K, i understood that wrongly. But you do say phy_probe(), not
PHY probe(), so it was my error.
Andrew
next prev parent reply other threads:[~2026-05-19 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 8:23 [PATCH net v2 0/2] net: phy: honor eee_disabled_modes when advertising EEE Nicolai Buchwitz
2026-05-18 8:23 ` [PATCH net v2 1/2] net: phy: honor eee_disabled_modes in phy_support_eee() Nicolai Buchwitz
2026-05-19 2:19 ` Andrew Lunn
2026-05-19 6:20 ` Nicolai Buchwitz
2026-05-19 11:56 ` Andrew Lunn [this message]
2026-05-18 8:23 ` [PATCH net v2 2/2] net: phy: honor eee_disabled_modes in phy_advertise_eee_all() Nicolai Buchwitz
2026-05-19 11:56 ` Andrew Lunn
2026-05-20 2:00 ` [PATCH net v2 0/2] net: phy: honor eee_disabled_modes when advertising EEE patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d11744b-e235-437d-b14d-3b49e0e162ef@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®