* [PATCH] sched/headers: Remove duplicated struct rq declare
@ 2023-12-07 12:19 WangJinchao
2023-12-12 22:26 ` Tim Chen
2023-12-18 13:51 ` Vincent Guittot
0 siblings, 2 replies; 3+ messages in thread
From: WangJinchao @ 2023-12-07 12:19 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider, linux-kernel
Cc: stone.xulei, wangjinchao
`struct rq` has been declared at the top of the file,
so remove the second declaration.
Signed-off-by: WangJinchao <wangjinchao@xfusion.com>
---
kernel/sched/sched.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 2e5a95486a42..349c90554bd8 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -931,7 +931,6 @@ struct uclamp_rq {
DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
#endif /* CONFIG_UCLAMP_TASK */
-struct rq;
struct balance_callback {
struct balance_callback *next;
void (*func)(struct rq *rq);
--
2.40.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched/headers: Remove duplicated struct rq declare
2023-12-07 12:19 [PATCH] sched/headers: Remove duplicated struct rq declare WangJinchao
@ 2023-12-12 22:26 ` Tim Chen
2023-12-18 13:51 ` Vincent Guittot
1 sibling, 0 replies; 3+ messages in thread
From: Tim Chen @ 2023-12-12 22:26 UTC (permalink / raw)
To: WangJinchao, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, Valentin Schneider,
linux-kernel
Cc: stone.xulei
On Thu, 2023-12-07 at 20:19 +0800, WangJinchao wrote:
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <wangjinchao@xfusion.com>
> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
> DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
> struct balance_callback {
> struct balance_callback *next;
> void (*func)(struct rq *rq);
Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
Tim
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched/headers: Remove duplicated struct rq declare
2023-12-07 12:19 [PATCH] sched/headers: Remove duplicated struct rq declare WangJinchao
2023-12-12 22:26 ` Tim Chen
@ 2023-12-18 13:51 ` Vincent Guittot
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Guittot @ 2023-12-18 13:51 UTC (permalink / raw)
To: WangJinchao
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Dietmar Eggemann,
Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider, linux-kernel,
stone.xulei
On Thu, 7 Dec 2023 at 13:20, WangJinchao <wangjinchao@xfusion.com> wrote:
>
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <wangjinchao@xfusion.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
> DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
> struct balance_callback {
> struct balance_callback *next;
> void (*func)(struct rq *rq);
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-18 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-07 12:19 [PATCH] sched/headers: Remove duplicated struct rq declare WangJinchao
2023-12-12 22:26 ` Tim Chen
2023-12-18 13:51 ` Vincent Guittot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®