* [PATCH] drm/vmwgfx: fix typo of sizeof argument
@ 2023-09-05 10:02 Konstantin Meskhidze
2023-09-06 2:44 ` Zack Rusin
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Meskhidze @ 2023-09-05 10:02 UTC (permalink / raw)
To: zackr
Cc: linux-graphics-maintainer, airlied, daniel, airlied, thellstrom,
dri-devel, linux-kernel, yusongping, artem.kuzin
Since size of 'header' pointer and '*header' structure is equal on 64-bit
machines issue probably didn't cause any wrong behavior. But anyway,
fixing typo is required.
Fixes: 7a73ba7469cb ("drm/vmwgfx: Use TTM handles instead of SIDs as user-space surface handles.")
Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 98e0723ca6f5..cc3f301ca163 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -1619,7 +1619,7 @@ static int vmw_cmd_tex_state(struct vmw_private *dev_priv,
{
VMW_DECLARE_CMD_VAR(*cmd, SVGA3dCmdSetTextureState);
SVGA3dTextureState *last_state = (SVGA3dTextureState *)
- ((unsigned long) header + header->size + sizeof(header));
+ ((unsigned long) header + header->size + sizeof(*header));
SVGA3dTextureState *cur_state = (SVGA3dTextureState *)
((unsigned long) header + sizeof(*cmd));
struct vmw_resource *ctx;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/vmwgfx: fix typo of sizeof argument
2023-09-05 10:02 [PATCH] drm/vmwgfx: fix typo of sizeof argument Konstantin Meskhidze
@ 2023-09-06 2:44 ` Zack Rusin
0 siblings, 0 replies; 2+ messages in thread
From: Zack Rusin @ 2023-09-06 2:44 UTC (permalink / raw)
To: konstantin.meskhidze
Cc: airlied, thellstrom, yusongping, dri-devel, airlied,
linux-kernel, Linux-graphics-maintainer, daniel, artem.kuzin
On Tue, 2023-09-05 at 18:02 +0800, Konstantin Meskhidze wrote:
> Since size of 'header' pointer and '*header' structure is equal on 64-bit
> machines issue probably didn't cause any wrong behavior. But anyway,
> fixing typo is required.
>
> Fixes: 7a73ba7469cb ("drm/vmwgfx: Use TTM handles instead of SIDs as user-space
> surface handles.")
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 98e0723ca6f5..cc3f301ca163 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -1619,7 +1619,7 @@ static int vmw_cmd_tex_state(struct vmw_private *dev_priv,
> {
> VMW_DECLARE_CMD_VAR(*cmd, SVGA3dCmdSetTextureState);
> SVGA3dTextureState *last_state = (SVGA3dTextureState *)
> - ((unsigned long) header + header->size + sizeof(header));
> + ((unsigned long) header + header->size + sizeof(*header));
> SVGA3dTextureState *cur_state = (SVGA3dTextureState *)
> ((unsigned long) header + sizeof(*cmd));
> struct vmw_resource *ctx;
Hah, yea, that's an old one. Thanks! I can push it through the drm-misc tree.
Reviewed-by: Zack Rusin <zackr@vmware.com>
z
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-06 2:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-05 10:02 [PATCH] drm/vmwgfx: fix typo of sizeof argument Konstantin Meskhidze
2023-09-06 2:44 ` Zack Rusin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®