From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Safocl Stollmannovic <safocl88@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 08/14] drivers: fix duplicate extern declarations
Date: Mon, 16 Nov 2026 09:31:39 -0800 [thread overview]
Message-ID: <0d7248af-3766-47a6-9150-ffebd6d5c501@broadcom.com> (raw)
In-Reply-To: <20261114165612.368785-9-safocl88@gmail.com>
On 11/14/26 08:55, Safocl Stollmannovic wrote:
> Compiling a kernel module with a C++ compiler results in a "duplicate
> extern specifier" error.
> This occurs because the code contains `extern asmlinkage`, and `asmlinkage`
> expands to `extern C` when processed by a C++ compiler.
> Since the code already contains sections that respond to a C++ compiler,
> I believe it is a perfectly valid approach to gradually move toward a state
> where kernel modules can be compiled by a C++ compiler without any issues.
> The `extern` specifier must be removed.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=222257
> Signed-off-by: Safocl Stollmannovic <safocl88@gmail.com>
I applied v2 which was not different to this tree:
https://github.com/Broadcom/stblinux/commit/0cab822bca7a59667774725b83e948b71462290f
the subject was reworded because yours was not specific enough and did
not match contributions made to this file previously.
--
Florian
next prev parent reply other threads:[~2026-11-16 17:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 16:55 [PATCH v3 00/14] Remove redundant " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 01/14] ARM: fix duplicate " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 02/14] loongarch: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 03/14] microblaze: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 04/14] MIPS: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 05/14] openrisc: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 06/14] riscv: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 07/14] x86: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 08/14] drivers: " Safocl Stollmannovic
2026-11-16 17:31 ` Florian Fainelli [this message]
2026-11-14 16:55 ` [PATCH v3 09/14] sched/preempt: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 10/14] lockdep: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 11/14] printk: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 12/14] shed/task: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 13/14] start_kernel: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 14/14] suspend: " Safocl Stollmannovic
2026-11-16 18:58 [PATCH v3 08/14] drivers: " Safocl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7248af-3766-47a6-9150-ffebd6d5c501@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=safocl88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®