From: Ralph Boehme <slow@samba.org>
To: Steve French <smfrench@gmail.com>
Cc: tanze <tanze@kylinos.cn>,
sfrench@samba.org, linkinjeon@kernel.org, pc@manguebit.org,
sprasad@microsoft.com, tom@talpey.com, senozhatsky@chromium.org,
chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org, Jeremy Allison <jra@samba.org>,
Stefan Metzmacher <metze@samba.org>
Subject: Re: [RFC PATCH v2 6/9] ksmbd: support security.capability EAs
Date: Tue, 21 Jul 2026 19:10:25 +0200 [thread overview]
Message-ID: <0d7bf668-cf21-4513-8817-6cea3cfce689@samba.org> (raw)
In-Reply-To: <CAH2r5mubDD4rFZUVTMibVN+up=uNps5HeOv8ehLBXR8GHF3fXA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1894 bytes --]
On 7/21/26 6:41 PM, Steve French wrote:
> On Tue, Jul 21, 2026 at 8:48 AM Ralph Boehme <slow@samba.org> wrote:
>>
>> On 7/20/26 3:06 PM, tanze wrote:
>>> Thanks for your question. When the CIFS client accesses user.EA, the
>>> name transmitted over the SMB protocol is simply EA instead of user.EA.
>>> ksmbd then prepends user. to convert it back to user.EA. If we pass
>>> every attribute name directly to the VFS unmodified, other types of
>>> extended attributes will return -EOPNOTSUPP due to missing handlers.
>>
>> yup, but I guess that's exactly what we want.
>>
>> If I get that right your proposal is
>>
>> Client Network Server
>> -------------------------------------------------
>> user.foo foo user.foo
>> system.bar system.bar system.bar
>>
>> This seems wrong (user namespace not prefixed, others prefixed).
>
> This approach at least doesn't require changing the protocol.
By definition we're defining an SMB3 POSIX protocol here, so I think we
should strive for a protocol that is consistent rather than encoding
historic Linux-specific implementation details.
In the proposal above, user.* is treated differently from every other
namespace:
user.foo -> foo
system.bar -> system.bar
That means the wire format no longer has a uniform representation of an
extended attribute. Whether a namespace is transmitted depends on which
namespace it is, which makes the protocol less self-describing and
introduces a special case that every implementation has to know about.
This is horrible.
If the protocol instead carries namespace and attribute name as separate
fields, every namespace is represented uniformly. Linux, FreeBSD, and
any future implementation simply map their local namespace
representation to the protocol, rather than the protocol inheriting
Linux's conventions.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2026-07-21 17:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 3:39 [RFC PATCH v2 0/9] smb: support security and trusted xattrs over EAs Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 1/9] smb: client: support security.capability " Ze Tan
2026-07-20 5:21 ` Namjae Jeon
2026-07-17 3:39 ` [RFC PATCH v2 2/9] smb: client: support security.xfstests " Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 3/9] smb: client: support trusted xattrs " Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 4/9] ksmbd: extract SMB EA backing xattr name mapping Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 5/9] ksmbd: extract SMB EA response name handling Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 6/9] ksmbd: support security.capability EAs Ze Tan
2026-07-20 6:57 ` Ralph Boehme
2026-07-20 13:06 ` tanze
2026-07-21 13:38 ` Ralph Boehme
2026-07-21 16:41 ` Steve French
2026-07-21 17:10 ` Ralph Boehme [this message]
2026-07-17 3:39 ` [RFC PATCH v2 7/9] ksmbd: support security.xfstests EAs Ze Tan
2026-07-20 5:03 ` Namjae Jeon
2026-07-20 6:33 ` tanze
2026-07-20 6:36 ` tanze
2026-07-17 3:39 ` [RFC PATCH v2 8/9] ksmbd: support trusted EAs Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 9/9] ksmbd: avoid self oplock breaks for EA opens Ze Tan
2026-07-20 5:34 ` Namjae Jeon
2026-07-20 8:54 ` tanze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7bf668-cf21-4513-8817-6cea3cfce689@samba.org \
--to=slow@samba.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=jra@samba.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=pc@manguebit.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tanze@kylinos.cn \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®