From: Namjae Jeon <linkinjeon@kernel.org>
To: Ze Tan <tanze@kylinos.cn>
Cc: sfrench@samba.org, pc@manguebit.org, sprasad@microsoft.com,
tom@talpey.comm, senozhatsky@chromium.org,
chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 7/9] ksmbd: support security.xfstests EAs
Date: Mon, 20 Jul 2026 14:03:58 +0900 [thread overview]
Message-ID: <CAKYAXd-iOpGsVBb3phdDVsNGf0doEzhHuKENB-cqHFc+AD8fFg@mail.gmail.com> (raw)
In-Reply-To: <a5a362d962c22a0f447c1398db5256be5399488c.1784258165.git.tanze@kylinos.cn>
> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
> index 2159b45c80a6..da3d5c217577 100644
> --- a/fs/smb/server/smb2pdu.c
> +++ b/fs/smb/server/smb2pdu.c
> @@ -2650,11 +2650,21 @@ static bool ksmbd_is_security_capability_ea_name(const char *name,
> !strncmp(name, XATTR_NAME_CAPS, name_len);
> }
>
> +static bool ksmbd_is_security_xfstests_ea_name(const char *name,
> + size_t name_len)
> +{
> + return name_len == sizeof(XATTR_SECURITY_PREFIX "xfstests") - 1 &&
> + !strncmp(name, XATTR_SECURITY_PREFIX "xfstests", name_len);
Is it appropriate to special-case an xfstests-only xattr name in ksmbd?
Could the security namespace support be implemented using a general,
well-defined policy instead?
Thanks.
next prev parent reply other threads:[~2026-07-20 5:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 3:39 [RFC PATCH v2 0/9] smb: support security and trusted xattrs over EAs Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 1/9] smb: client: support security.capability " Ze Tan
2026-07-20 5:21 ` Namjae Jeon
2026-07-17 3:39 ` [RFC PATCH v2 2/9] smb: client: support security.xfstests " Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 3/9] smb: client: support trusted xattrs " Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 4/9] ksmbd: extract SMB EA backing xattr name mapping Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 5/9] ksmbd: extract SMB EA response name handling Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 6/9] ksmbd: support security.capability EAs Ze Tan
2026-07-20 6:57 ` Ralph Boehme
2026-07-20 13:06 ` tanze
2026-07-21 13:38 ` Ralph Boehme
2026-07-21 16:41 ` Steve French
2026-07-21 17:10 ` Ralph Boehme
2026-07-17 3:39 ` [RFC PATCH v2 7/9] ksmbd: support security.xfstests EAs Ze Tan
2026-07-20 5:03 ` Namjae Jeon [this message]
2026-07-20 6:33 ` tanze
2026-07-20 6:36 ` tanze
2026-07-17 3:39 ` [RFC PATCH v2 8/9] ksmbd: support trusted EAs Ze Tan
2026-07-17 3:39 ` [RFC PATCH v2 9/9] ksmbd: avoid self oplock breaks for EA opens Ze Tan
2026-07-20 5:34 ` Namjae Jeon
2026-07-20 8:54 ` tanze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd-iOpGsVBb3phdDVsNGf0doEzhHuKENB-cqHFc+AD8fFg@mail.gmail.com \
--to=linkinjeon@kernel.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tanze@kylinos.cn \
--cc=tom@talpey.comm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®