[PATCH] kbuild: dummy-tools: support make MPROFILE_KERNEL checks work on BE

[PATCH] kbuild: dummy-tools: support make MPROFILE_KERNEL checks work on BE

[Jiri Slaby (SUSE)]

From: Jiri Slaby <jslaby@suse.cz>

Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL
checks for ppc") added support for ppc64le's checks for
-mprofile-kernel.

Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big
endian ELFv2 kernels") added support for -mprofile-kernel even on
big-endian ppc.

So lift the check in gcc-check-mprofile-kernel.sh to support big-endian too.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nicolas Schier <nicolas@fjasle.eu>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michal Kubecek <mkubecek@suse.cz>
---
 scripts/dummy-tools/gcc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
index 1db1889f6d81..07f6dc4c5cf6 100755
--- a/scripts/dummy-tools/gcc
+++ b/scripts/dummy-tools/gcc
@@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
 	fi
 
 	# For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
-	if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
-		arg_contain -mprofile-kernel "$@"; then
+	if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; then
 		if ! test -t 0 && ! grep -q notrace; then
 			echo "_mcount"
 		fi
-- 
2.42.0

Re: [PATCH] kbuild: dummy-tools: support make MPROFILE_KERNEL checks work on BE

[Jiri Slaby]

I deleted too few: the subject should read:
kbuild: dummy-tools: make MPROFILE_KERNEL checks work on BE

I will submit v2 if there are no other objections.

On 29. 08. 23, 12:51, Jiri Slaby (SUSE) wrote:
> From: Jiri Slaby <jslaby@suse.cz>
> 
> Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL
> checks for ppc") added support for ppc64le's checks for
> -mprofile-kernel.
> 
> Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big
> endian ELFv2 kernels") added support for -mprofile-kernel even on
> big-endian ppc.
> 
> So lift the check in gcc-check-mprofile-kernel.sh to support big-endian too.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Nicolas Schier <nicolas@fjasle.eu>
> Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Michal Kubecek <mkubecek@suse.cz>
> ---
>   scripts/dummy-tools/gcc | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> index 1db1889f6d81..07f6dc4c5cf6 100755
> --- a/scripts/dummy-tools/gcc
> +++ b/scripts/dummy-tools/gcc
> @@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
>   	fi
>   
>   	# For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
> -	if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
> -		arg_contain -mprofile-kernel "$@"; then
> +	if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; then
>   		if ! test -t 0 && ! grep -q notrace; then
>   			echo "_mcount"
>   		fi

-- 
js
suse labs

Re: [PATCH] kbuild: dummy-tools: support make MPROFILE_KERNEL checks work on BE

[Masahiro Yamada]

On Wed, Aug 30, 2023 at 2:00 AM Jiri Slaby <jirislaby@kernel.org> wrote:
>
> I deleted too few: the subject should read:
> kbuild: dummy-tools: make MPROFILE_KERNEL checks work on BE
>
> I will submit v2 if there are no other objections.


I have no objection.

If there is nothing else to fix,
I will locally fix the subject, and apply.


I also see a similar patch from Michal Suchanek,
but I like this one because the commit log
has a good explanation.



> On 29. 08. 23, 12:51, Jiri Slaby (SUSE) wrote:
> > From: Jiri Slaby <jslaby@suse.cz>
> >
> > Commit 2eab791f940b ("kbuild: dummy-tools: support MPROFILE_KERNEL
> > checks for ppc") added support for ppc64le's checks for
> > -mprofile-kernel.
> >
> > Now, commit aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big
> > endian ELFv2 kernels") added support for -mprofile-kernel even on
> > big-endian ppc.
> >
> > So lift the check in gcc-check-mprofile-kernel.sh to support big-endian too.
> >
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Nicolas Schier <nicolas@fjasle.eu>
> > Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Cc: Nicholas Piggin <npiggin@gmail.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Michal Kubecek <mkubecek@suse.cz>
> > ---
> >   scripts/dummy-tools/gcc | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> > index 1db1889f6d81..07f6dc4c5cf6 100755
> > --- a/scripts/dummy-tools/gcc
> > +++ b/scripts/dummy-tools/gcc
> > @@ -85,8 +85,7 @@ if arg_contain -S "$@"; then
> >       fi
> >
> >       # For arch/powerpc/tools/gcc-check-mprofile-kernel.sh
> > -     if arg_contain -m64 "$@" && arg_contain -mlittle-endian "$@" &&
> > -             arg_contain -mprofile-kernel "$@"; then
> > +     if arg_contain -m64 "$@" && arg_contain -mprofile-kernel "$@"; then
> >               if ! test -t 0 && ! grep -q notrace; then
> >                       echo "_mcount"
> >               fi
>
> --
> js
> suse labs
>


-- 
Best Regards
Masahiro Yamada