mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: yu kuai <yukuai3@huawei.com>, dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@linux.ie>, Eric Anholt <eric@anholt.net>,
	Yi Zhang <yi.zhang@huawei.com>, zhengbin <zhengbin13@huawei.com>
Subject: Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
Date: Sat, 28 Dec 2019 21:45:52 +0100	[thread overview]
Message-ID: <0db93c30-2c87-9824-31be-a15c0d141ab5@web.de> (raw)
In-Reply-To: <20191225131715.3527-1-yukuai3@huawei.com>

> v3d_submit_cl_ioctl call kfree() with variable 'bin' twice.

I would prefer a wording like “kfree() was called for the same variable twice
within an if branch.”.


> Fix it by removing the latter one.

I find the wording “Delete a duplicate function call.” more appropriate.

Please add the tag “Fixes” to your change description.

Regards,
Markus

  reply	other threads:[~2019-12-28 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-25 13:17 yu kuai
2019-12-28 20:45 ` Markus Elfring [this message]
2019-12-29  1:19   ` yukuai (C)
2019-12-29 12:14     ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0db93c30-2c87-9824-31be-a15c0d141ab5@web.de \
    --to=markus.elfring@web.de \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®