From: Markus Elfring <Markus.Elfring@web.de>
To: yu kuai <yukuai3@huawei.com>, Daniel Vetter <daniel@ffwll.ch>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
Eric Anholt <eric@anholt.net>,
dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
Yi Zhang <yi.zhang@huawei.com>, zhengbin <zhengbin13@huawei.com>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>
Subject: Re: drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl
Date: Sun, 29 Dec 2019 13:14:03 +0100 [thread overview]
Message-ID: <55da3be6-ea90-e554-775a-de610b8fbf7b@web.de> (raw)
In-Reply-To: <23c5fdc5-b5ee-fd61-4c33-5e4442cdf305@huawei.com>
>> Please add the tag “Fixes” to your change description.
>
> I got the results from "git blame":
> git blame -L 570,575 drivers/gpu/drm/v3d/v3d_gem.c
…
> 0d352a3a8a1f2 (Iago Toral Quiroga 2019-09-16 09:11:25 +0200 571) kfree(bin);
> a783a09ee76d6 (Eric Anholt 2019-04-16 15:58:53 -0700 572) v3d_job_put(&render->base);
> 29cd13cfd7624 (Navid Emamdoost 2019-10-21 13:52:49 -0500 573) kfree(bin);
> a783a09ee76d6 (Eric Anholt 2019-04-16 15:58:53 -0700 574) return ret;
…
>
…
> commit 29cd13cfd7624726d9e6becbae9aa419ef35af7f
> Author: Navid Emamdoost <navid.emamdoost@gmail.com>
> Date: Mon Oct 21 13:52:49 2019 -0500
>
> drm/v3d: Fix memory leak in v3d_submit_cl_ioctl
>
> In the impelementation of v3d_submit_cl_ioctl() there are two memory
…
It seems that this patch got insufficient code review attention before.
https://lore.kernel.org/dri-devel/20191021185250.26130-1-navid.emamdoost@gmail.com/
https://lore.kernel.org/patchwork/comment/1342088/
https://lore.kernel.org/patchwork/patch/1142603/
Thus the fix chain will be extended.
Regards,
Markus
prev parent reply other threads:[~2019-12-29 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 13:17 [PATCH] " yu kuai
2019-12-28 20:45 ` Markus Elfring
2019-12-29 1:19 ` yukuai (C)
2019-12-29 12:14 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55da3be6-ea90-e554-775a-de610b8fbf7b@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=eric@anholt.net \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome