* Re: [PATCH] arm64: dts: exynos: add abox generic for ExynosAutov920
2025-07-09 0:12 ` [PATCH] arm64: dts: exynos: add abox generic for ExynosAutov920 ew kim
@ 2025-07-09 6:44 ` Krzysztof Kozlowski
2025-07-09 14:00 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-09 6:44 UTC (permalink / raw)
To: ew kim, robh, krzk+dt, conor+dt
Cc: alim.akhtar, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel
On 09/07/2025 02:12, ew kim wrote:
> Add a node for Abox generic. This driver, exynosautov920, connects to
> the SoC and allows you to configure a sound card.
DTS is not for drivers. NAK.
>
> Signed-off-by: ew kim <ew.kim@samsung.com>
> ---
> .../boot/dts/exynos/exynosautov920-audio.dtsi | 20 +++++++++++++++++++
> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 1 +
> 2 files changed, 21 insertions(+)
> create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi
> new file mode 100644
> index 000000000000..4a1341ccdc2e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2020 Samsung Electronics Co., Ltd.
You need to clean up old downstream code. Read DTS coding style.
> + * http://www.samsung.com/
> + *
> + * EXYNOS - Audio Device Tree source
> + */
> +
> +/ {
> + abox_generic: abox_generic@generic {
> + compatible = "samsung,abox_generic";
> + samsung,num-of-pcm_playback = <32>;
> + samsung,num-of-pcm_capture = <32>;
> + samsung,num-of-i2s-dummy-backend = <5>;
> + status = "disabled";
You just add dead code. This is very poor submission. Reach internally
(or to experienced R&D in Poland) to guide you how to submit proper patches.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: exynos: add abox generic for ExynosAutov920
2025-07-09 0:12 ` [PATCH] arm64: dts: exynos: add abox generic for ExynosAutov920 ew kim
2025-07-09 6:44 ` Krzysztof Kozlowski
@ 2025-07-09 14:00 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-07-09 14:00 UTC (permalink / raw)
To: ew kim
Cc: krzk+dt, linux-kernel, linux-arm-kernel, conor+dt,
linux-samsung-soc, devicetree, alim.akhtar
On Wed, 09 Jul 2025 09:12:10 +0900, ew kim wrote:
> Add a node for Abox generic. This driver, exynosautov920, connects to
> the SoC and allows you to configure a sound card.
>
> Signed-off-by: ew kim <ew.kim@samsung.com>
> ---
> .../boot/dts/exynos/exynosautov920-audio.dtsi | 20 +++++++++++++++++++
> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 1 +
> 2 files changed, 21 insertions(+)
> create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: failed to guess base
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250709001210.379418-1-ew.kim@samsung.com:
arch/arm64/boot/dts/exynos/exynosautov920-audio.dtsi:18.3-10: Warning (ranges_format): /abox_generic@generic:ranges: empty "ranges" property but its #size-cells (1) differs from / (2)
arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: / (samsung,exynosautov920-sadk): 'abox_generic@generic' does not match any of the regexes: '.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-9,+\-._]{0,63}$', '^[a-zA-Z0-9][a-zA-Z0-9#,+\-._]{0,63}$', '^[a-zA-Z0-9][a-zA-Z0-9,+\-._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$', '^__.*__$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: /abox_generic@generic: failed to match any schema with compatible: ['samsung,abox_generic']
^ permalink raw reply [flat|nested] 3+ messages in thread