From: John Garry <john.garry@linux.dev>
To: Manuel Ebner <manuelebnerli@mailbox.org>,
Jason Yan <yanaijie@huawei.com>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: libsas: Fix interval notation
Date: Tue, 3 Nov 2026 17:01:53 +0000 [thread overview]
Message-ID: <0dce8e2f-e039-45f1-9579-91cad6563a66@linux.dev> (raw)
In-Reply-To: <2deda25727af9db748f86f2a3d1f61047c903f3a.camel@mailbox.org>
On 11/3/26 14:25, Manuel Ebner wrote:
> On Wed, 2026-09-16 at 14:40 +0100, John Garry wrote:
>> On 9/16/26 13:44, Manuel Ebner wrote:
>>> Remove needless ']' from interval boundary.
>>>
>>
>> This documentation is wrong for this structure description (not shown) -
>> it should be for asd_sas_phy, not sas_phy
>>
>> Same for sas_port -> asd_sas_port
>
> Does replacing all sas_phy -> asd_sas_phy and sas_port -> asd_sas_port
> fix this? Then I'll send a patch.
>
uh, I don't think that anyone would be checking this documentation from
now on, as I don't expect any drivers for new SAS HBAs which may even
want to use libsas will appear.
John
> Thanks> Manuel
>
>
>>
>>> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
>>> ---
>>> Documentation/scsi/libsas.rst | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst
>>> index 305a253d5..9ebf2bf28 100644
>>> --- a/Documentation/scsi/libsas.rst
>>> +++ b/Documentation/scsi/libsas.rst
>>> @@ -75,7 +75,7 @@ enabled
>>> - must be set (0/1)
>>>
>>> id
>>> - - must be set [0,MAX_PHYS)]
>>> + - must be set [0,MAX_PHYS)
>>
>> this looks ok, even though it is so trivial
>>
>>>
>>> class, proto, type, role, oob_mode, linkrate
>>> - must be set
prev parent reply other threads:[~2026-11-03 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 12:44 Manuel Ebner
2026-09-16 13:40 ` John Garry
2026-11-03 14:25 ` Manuel Ebner
2026-11-03 17:01 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dce8e2f-e039-45f1-9579-91cad6563a66@linux.dev \
--to=john.garry@linux.dev \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manuelebnerli@mailbox.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®