* [PATCH] scsi: libsas: Fix interval notation
@ 2026-09-16 12:44 Manuel Ebner
2026-09-16 13:40 ` John Garry
0 siblings, 1 reply; 4+ messages in thread
From: Manuel Ebner @ 2026-09-16 12:44 UTC (permalink / raw)
To: John Garry, Jason Yan, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: Manuel Ebner, linux-scsi, linux-doc, linux-kernel
Remove needless ']' from interval boundary.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
Documentation/scsi/libsas.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst
index 305a253d5..9ebf2bf28 100644
--- a/Documentation/scsi/libsas.rst
+++ b/Documentation/scsi/libsas.rst
@@ -75,7 +75,7 @@ enabled
- must be set (0/1)
id
- - must be set [0,MAX_PHYS)]
+ - must be set [0,MAX_PHYS)
class, proto, type, role, oob_mode, linkrate
- must be set
--
2.55.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libsas: Fix interval notation
2026-09-16 12:44 [PATCH] scsi: libsas: Fix interval notation Manuel Ebner
@ 2026-09-16 13:40 ` John Garry
2026-11-03 14:25 ` Manuel Ebner
0 siblings, 1 reply; 4+ messages in thread
From: John Garry @ 2026-09-16 13:40 UTC (permalink / raw)
To: Manuel Ebner, John Garry, Jason Yan, Jonathan Corbet, Shuah Khan,
Randy Dunlap
Cc: linux-scsi, linux-doc, linux-kernel
On 9/16/26 13:44, Manuel Ebner wrote:
> Remove needless ']' from interval boundary.
>
This documentation is wrong for this structure description (not shown) -
it should be for asd_sas_phy, not sas_phy
Same for sas_port -> asd_sas_port
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> Documentation/scsi/libsas.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst
> index 305a253d5..9ebf2bf28 100644
> --- a/Documentation/scsi/libsas.rst
> +++ b/Documentation/scsi/libsas.rst
> @@ -75,7 +75,7 @@ enabled
> - must be set (0/1)
>
> id
> - - must be set [0,MAX_PHYS)]
> + - must be set [0,MAX_PHYS)
this looks ok, even though it is so trivial
>
> class, proto, type, role, oob_mode, linkrate
> - must be set
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libsas: Fix interval notation
2026-09-16 13:40 ` John Garry
@ 2026-11-03 14:25 ` Manuel Ebner
2026-11-03 17:01 ` John Garry
0 siblings, 1 reply; 4+ messages in thread
From: Manuel Ebner @ 2026-11-03 14:25 UTC (permalink / raw)
To: John Garry, John Garry, Jason Yan, Jonathan Corbet, Shuah Khan,
Randy Dunlap
Cc: linux-scsi, linux-doc, linux-kernel
On Wed, 2026-09-16 at 14:40 +0100, John Garry wrote:
> On 9/16/26 13:44, Manuel Ebner wrote:
> > Remove needless ']' from interval boundary.
> >
>
> This documentation is wrong for this structure description (not shown) -
> it should be for asd_sas_phy, not sas_phy
>
> Same for sas_port -> asd_sas_port
Does replacing all sas_phy -> asd_sas_phy and sas_port -> asd_sas_port
fix this? Then I'll send a patch.
Thanks
Manuel
>
> > Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> > ---
> > Documentation/scsi/libsas.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst
> > index 305a253d5..9ebf2bf28 100644
> > --- a/Documentation/scsi/libsas.rst
> > +++ b/Documentation/scsi/libsas.rst
> > @@ -75,7 +75,7 @@ enabled
> > - must be set (0/1)
> >
> > id
> > - - must be set [0,MAX_PHYS)]
> > + - must be set [0,MAX_PHYS)
>
> this looks ok, even though it is so trivial
>
> >
> > class, proto, type, role, oob_mode, linkrate
> > - must be set
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libsas: Fix interval notation
2026-11-03 14:25 ` Manuel Ebner
@ 2026-11-03 17:01 ` John Garry
0 siblings, 0 replies; 4+ messages in thread
From: John Garry @ 2026-11-03 17:01 UTC (permalink / raw)
To: Manuel Ebner, Jason Yan, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: linux-scsi, linux-doc, linux-kernel
On 11/3/26 14:25, Manuel Ebner wrote:
> On Wed, 2026-09-16 at 14:40 +0100, John Garry wrote:
>> On 9/16/26 13:44, Manuel Ebner wrote:
>>> Remove needless ']' from interval boundary.
>>>
>>
>> This documentation is wrong for this structure description (not shown) -
>> it should be for asd_sas_phy, not sas_phy
>>
>> Same for sas_port -> asd_sas_port
>
> Does replacing all sas_phy -> asd_sas_phy and sas_port -> asd_sas_port
> fix this? Then I'll send a patch.
>
uh, I don't think that anyone would be checking this documentation from
now on, as I don't expect any drivers for new SAS HBAs which may even
want to use libsas will appear.
John
> Thanks> Manuel
>
>
>>
>>> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
>>> ---
>>> Documentation/scsi/libsas.rst | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/scsi/libsas.rst b/Documentation/scsi/libsas.rst
>>> index 305a253d5..9ebf2bf28 100644
>>> --- a/Documentation/scsi/libsas.rst
>>> +++ b/Documentation/scsi/libsas.rst
>>> @@ -75,7 +75,7 @@ enabled
>>> - must be set (0/1)
>>>
>>> id
>>> - - must be set [0,MAX_PHYS)]
>>> + - must be set [0,MAX_PHYS)
>>
>> this looks ok, even though it is so trivial
>>
>>>
>>> class, proto, type, role, oob_mode, linkrate
>>> - must be set
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-03 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-16 12:44 [PATCH] scsi: libsas: Fix interval notation Manuel Ebner
2026-09-16 13:40 ` John Garry
2026-11-03 14:25 ` Manuel Ebner
2026-11-03 17:01 ` John Garry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®