From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rafael@kernel.org
Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com,
amit.kachhap@gmail.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz,
mhiramat@kernel.org, qyousef@layalina.io, wvw@google.com,
xuewen.yan94@gmail.com
Subject: Re: [PATCH v7 16/23] powercap/dtpm_cpu: Use new Energy Model interface to get table
Date: Mon, 29 Jan 2024 19:14:17 +0100 [thread overview]
Message-ID: <0dce919b-279d-4a34-8641-09d0acec5cf1@arm.com> (raw)
In-Reply-To: <20240117095714.1524808-17-lukasz.luba@arm.com>
On 17/01/2024 10:57, Lukasz Luba wrote:
[...]
> drivers/powercap/dtpm_cpu.c | 39 +++++++++++++++++++++++++++----------
> 1 file changed, 29 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
> index 9193c3b8edeb..ee0d1aa3e023 100644
> --- a/drivers/powercap/dtpm_cpu.c
> +++ b/drivers/powercap/dtpm_cpu.c
> @@ -42,6 +42,7 @@ static u64 set_pd_power_limit(struct dtpm *dtpm, u64 power_limit)
> {
> struct dtpm_cpu *dtpm_cpu = to_dtpm_cpu(dtpm);
> struct em_perf_domain *pd = em_cpu_get(dtpm_cpu->cpu);
> + struct em_perf_state *table;
> struct cpumask cpus;
> unsigned long freq;
> u64 power;
> @@ -50,20 +51,22 @@ static u64 set_pd_power_limit(struct dtpm *dtpm, u64 power_limit)
> cpumask_and(&cpus, cpu_online_mask, to_cpumask(pd->cpus));
> nr_cpus = cpumask_weight(&cpus);
>
> + rcu_read_lock();
> + table = em_perf_state_from_pd(pd);
'table' vs. 'perf state(s)' ... another example (compare to comment in
12/23).
[...]
next prev parent reply other threads:[~2024-01-29 18:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 9:56 [PATCH v7 00/23] Introduce runtime modifiable Energy Model Lukasz Luba
2024-01-17 9:56 ` [PATCH v7 01/23] PM: EM: Add missing newline for the message log Lukasz Luba
2024-01-17 11:02 ` Hongyan Xia
2024-01-17 9:56 ` [PATCH v7 02/23] PM: EM: Extend em_cpufreq_update_efficiencies() argument list Lukasz Luba
2024-01-17 11:10 ` Hongyan Xia
2024-01-17 9:56 ` [PATCH v7 03/23] PM: EM: Find first CPU active while updating OPP efficiency Lukasz Luba
2024-01-17 12:05 ` Hongyan Xia
2024-01-17 9:56 ` [PATCH v7 04/23] PM: EM: Refactor em_pd_get_efficient_state() to be more flexible Lukasz Luba
2024-01-17 12:45 ` Hongyan Xia
2024-02-06 13:53 ` Lukasz Luba
2024-01-17 9:56 ` [PATCH v7 05/23] PM: EM: Introduce em_compute_costs() Lukasz Luba
2024-01-17 9:56 ` [PATCH v7 06/23] PM: EM: Check if the get_cost() callback is present in em_compute_costs() Lukasz Luba
2024-01-17 9:56 ` [PATCH v7 07/23] PM: EM: Split the allocation and initialization of the EM table Lukasz Luba
2024-01-17 9:56 ` [PATCH v7 08/23] PM: EM: Introduce runtime modifiable table Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 09/23] PM: EM: Use runtime modified EM for CPUs energy estimation in EAS Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 10/23] PM: EM: Add functions for memory allocations for new EM tables Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 11/23] PM: EM: Introduce em_dev_update_perf_domain() for EM updates Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 12/23] PM: EM: Add em_perf_state_from_pd() to get performance states table Lukasz Luba
2024-01-29 18:13 ` Dietmar Eggemann
2024-02-06 13:55 ` Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 13/23] PM: EM: Add performance field to struct em_perf_state and optimize Lukasz Luba
2024-01-29 18:13 ` Dietmar Eggemann
2024-01-17 9:57 ` [PATCH v7 14/23] PM: EM: Support late CPUs booting and capacity adjustment Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 15/23] PM: EM: Optimize em_cpu_energy() and remove division Lukasz Luba
2024-02-07 11:40 ` Hongyan Xia
2024-01-17 9:57 ` [PATCH v7 16/23] powercap/dtpm_cpu: Use new Energy Model interface to get table Lukasz Luba
2024-01-29 18:14 ` Dietmar Eggemann [this message]
2024-01-17 9:57 ` [PATCH v7 17/23] powercap/dtpm_devfreq: " Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 18/23] drivers/thermal/cpufreq_cooling: Use new Energy Model interface Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 19/23] drivers/thermal/devfreq_cooling: " Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 20/23] PM: EM: Change debugfs configuration to use runtime EM table data Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 21/23] PM: EM: Remove old table Lukasz Luba
2024-01-17 9:57 ` [PATCH v7 22/23] PM: EM: Add em_dev_compute_costs() Lukasz Luba
2024-01-29 18:15 ` Dietmar Eggemann
2024-01-17 9:57 ` [PATCH v7 23/23] Documentation: EM: Update with runtime modification design Lukasz Luba
2024-01-29 18:16 ` [PATCH v7 00/23] Introduce runtime modifiable Energy Model Dietmar Eggemann
2024-02-06 13:54 ` Lukasz Luba
2024-02-07 9:15 ` Lukasz Luba
2024-02-07 10:31 ` Rafael J. Wysocki
2024-02-07 11:49 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dce919b-279d-4a34-8641-09d0acec5cf1@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mhiramat@kernel.org \
--cc=pavel@ucw.cz \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®