From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Oliver O'Halloran <oohall@gmail.com>
Cc: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<virtualization@lists.linux.dev>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
Date: Mon, 10 Jun 2024 07:03:36 -0700 [thread overview]
Message-ID: <0dcef87c-e5e0-4298-bf83-1794bbbc60ed@quicinc.com> (raw)
In-Reply-To: <6667067e7e152_1700b5294ed@iweiny-mobl.notmuch>
On 6/10/2024 6:58 AM, Ira Weiny wrote:
> Jeff Johnson wrote:
>> Fix the 'make W=1' warnings:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
>
> Just to double check. This is a resend of this patch?
>
> https://lore.kernel.org/all/20240526-md-drivers-nvdimm-v1-1-172e682e76bd@quicinc.com/
>
> Dave Jiang, I'm picking up all these for the nvdimm tree and I think there
> were a couple I was not CC'ed on. I'll coordinate with you because I'm
> still seeing a couple of these warnings on other modules in the test
> build.
>
> Also I want to double check all the descriptions before I send for 6.11.
>
> Jeff is it ok if I alter the text? I know you mentioned to Jonathan you
> really just wanted to see the errors go away.
Yes, please make the text whatever makes the most sense. In most of these
cases I'm not a domain expert so I construct these descriptions based upon
code comments, Kconfig descriptions, and git descriptions, and in some cases
these are originally wrong due to cut-n-paste or the drivers have evolved so
that information is no longer accurate.
I need to add a version of that to my b4 cover letter!
/jeff
prev parent reply other threads:[~2024-06-10 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 17:07 Jeff Johnson
2024-06-06 16:12 ` Dave Jiang
2024-06-10 13:58 ` Ira Weiny
2024-06-10 14:03 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dcef87c-e5e0-4298-bf83-1794bbbc60ed@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=oohall@gmail.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=virtualization@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®