* [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
@ 2024-05-26 17:07 Jeff Johnson
2024-06-06 16:12 ` Dave Jiang
2024-06-10 13:58 ` Ira Weiny
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-05-26 17:07 UTC (permalink / raw)
To: Vishal Verma, Dan Williams, Dave Jiang, Ira Weiny, Pankaj Gupta,
Oliver O'Halloran
Cc: nvdimm, linux-kernel, virtualization, kernel-janitors, Jeff Johnson
Fix the 'make W=1' warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/nvdimm/btt.c | 1 +
drivers/nvdimm/core.c | 1 +
drivers/nvdimm/e820.c | 1 +
drivers/nvdimm/nd_virtio.c | 1 +
drivers/nvdimm/of_pmem.c | 1 +
drivers/nvdimm/pmem.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index 1e5aedaf8c7b..a47acc5d05df 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -1721,6 +1721,7 @@ static void __exit nd_btt_exit(void)
MODULE_ALIAS_ND_DEVICE(ND_DEVICE_BTT);
MODULE_AUTHOR("Vishal Verma <vishal.l.verma@linux.intel.com>");
+MODULE_DESCRIPTION("NVDIMM Block Translation Table");
MODULE_LICENSE("GPL v2");
module_init(nd_btt_init);
module_exit(nd_btt_exit);
diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c
index 2023a661bbb0..f4b6fb4b9828 100644
--- a/drivers/nvdimm/core.c
+++ b/drivers/nvdimm/core.c
@@ -540,6 +540,7 @@ static __exit void libnvdimm_exit(void)
nvdimm_devs_exit();
}
+MODULE_DESCRIPTION("NVDIMM (Non-Volatile Memory Device) core module");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Intel Corporation");
subsys_initcall(libnvdimm_init);
diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c
index 4cd18be9d0e9..008b9aae74ff 100644
--- a/drivers/nvdimm/e820.c
+++ b/drivers/nvdimm/e820.c
@@ -69,5 +69,6 @@ static struct platform_driver e820_pmem_driver = {
module_platform_driver(e820_pmem_driver);
MODULE_ALIAS("platform:e820_pmem*");
+MODULE_DESCRIPTION("NVDIMM support for e820 type-12 memory");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Intel Corporation");
diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
index 1f8c667c6f1e..35c8fbbba10e 100644
--- a/drivers/nvdimm/nd_virtio.c
+++ b/drivers/nvdimm/nd_virtio.c
@@ -123,4 +123,5 @@ int async_pmem_flush(struct nd_region *nd_region, struct bio *bio)
return 0;
};
EXPORT_SYMBOL_GPL(async_pmem_flush);
+MODULE_DESCRIPTION("Virtio Persistent Memory Driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
index d3fca0ab6290..5134a8d08bf9 100644
--- a/drivers/nvdimm/of_pmem.c
+++ b/drivers/nvdimm/of_pmem.c
@@ -111,5 +111,6 @@ static struct platform_driver of_pmem_region_driver = {
module_platform_driver(of_pmem_region_driver);
MODULE_DEVICE_TABLE(of, of_pmem_region_match);
+MODULE_DESCRIPTION("NVDIMM Device Tree support");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("IBM Corporation");
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 598fe2e89bda..57cb30f8a3b8 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -768,4 +768,5 @@ static struct nd_device_driver nd_pmem_driver = {
module_nd_driver(nd_pmem_driver);
MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>");
+MODULE_DESCRIPTION("NVDIMM Persistent Memory Driver");
MODULE_LICENSE("GPL v2");
---
base-commit: 416ff45264d50a983c3c0b99f0da6ee59f9acd68
change-id: 20240526-md-drivers-nvdimm-121215a4b93f
--
Jeff Johnson <quic_jjohnson@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
2024-05-26 17:07 [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-06 16:12 ` Dave Jiang
2024-06-10 13:58 ` Ira Weiny
1 sibling, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2024-06-06 16:12 UTC (permalink / raw)
To: Jeff Johnson, Vishal Verma, Dan Williams, Ira Weiny,
Pankaj Gupta, Oliver O'Halloran
Cc: nvdimm, linux-kernel, virtualization, kernel-janitors
On 5/26/24 10:07 AM, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/nvdimm/btt.c | 1 +
> drivers/nvdimm/core.c | 1 +
> drivers/nvdimm/e820.c | 1 +
> drivers/nvdimm/nd_virtio.c | 1 +
> drivers/nvdimm/of_pmem.c | 1 +
> drivers/nvdimm/pmem.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index 1e5aedaf8c7b..a47acc5d05df 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1721,6 +1721,7 @@ static void __exit nd_btt_exit(void)
>
> MODULE_ALIAS_ND_DEVICE(ND_DEVICE_BTT);
> MODULE_AUTHOR("Vishal Verma <vishal.l.verma@linux.intel.com>");
> +MODULE_DESCRIPTION("NVDIMM Block Translation Table");
> MODULE_LICENSE("GPL v2");
> module_init(nd_btt_init);
> module_exit(nd_btt_exit);
> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c
> index 2023a661bbb0..f4b6fb4b9828 100644
> --- a/drivers/nvdimm/core.c
> +++ b/drivers/nvdimm/core.c
> @@ -540,6 +540,7 @@ static __exit void libnvdimm_exit(void)
> nvdimm_devs_exit();
> }
>
> +MODULE_DESCRIPTION("NVDIMM (Non-Volatile Memory Device) core module");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Intel Corporation");
> subsys_initcall(libnvdimm_init);
> diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c
> index 4cd18be9d0e9..008b9aae74ff 100644
> --- a/drivers/nvdimm/e820.c
> +++ b/drivers/nvdimm/e820.c
> @@ -69,5 +69,6 @@ static struct platform_driver e820_pmem_driver = {
> module_platform_driver(e820_pmem_driver);
>
> MODULE_ALIAS("platform:e820_pmem*");
> +MODULE_DESCRIPTION("NVDIMM support for e820 type-12 memory");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Intel Corporation");
> diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
> index 1f8c667c6f1e..35c8fbbba10e 100644
> --- a/drivers/nvdimm/nd_virtio.c
> +++ b/drivers/nvdimm/nd_virtio.c
> @@ -123,4 +123,5 @@ int async_pmem_flush(struct nd_region *nd_region, struct bio *bio)
> return 0;
> };
> EXPORT_SYMBOL_GPL(async_pmem_flush);
> +MODULE_DESCRIPTION("Virtio Persistent Memory Driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index d3fca0ab6290..5134a8d08bf9 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -111,5 +111,6 @@ static struct platform_driver of_pmem_region_driver = {
>
> module_platform_driver(of_pmem_region_driver);
> MODULE_DEVICE_TABLE(of, of_pmem_region_match);
> +MODULE_DESCRIPTION("NVDIMM Device Tree support");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("IBM Corporation");
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 598fe2e89bda..57cb30f8a3b8 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -768,4 +768,5 @@ static struct nd_device_driver nd_pmem_driver = {
> module_nd_driver(nd_pmem_driver);
>
> MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>");
> +MODULE_DESCRIPTION("NVDIMM Persistent Memory Driver");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 416ff45264d50a983c3c0b99f0da6ee59f9acd68
> change-id: 20240526-md-drivers-nvdimm-121215a4b93f
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
2024-05-26 17:07 [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-06 16:12 ` Dave Jiang
@ 2024-06-10 13:58 ` Ira Weiny
2024-06-10 14:03 ` Jeff Johnson
1 sibling, 1 reply; 4+ messages in thread
From: Ira Weiny @ 2024-06-10 13:58 UTC (permalink / raw)
To: Jeff Johnson, Vishal Verma, Dan Williams, Dave Jiang, Ira Weiny,
Pankaj Gupta, Oliver O'Halloran
Cc: nvdimm, linux-kernel, virtualization, kernel-janitors, Jeff Johnson
Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
Just to double check. This is a resend of this patch?
https://lore.kernel.org/all/20240526-md-drivers-nvdimm-v1-1-172e682e76bd@quicinc.com/
Dave Jiang, I'm picking up all these for the nvdimm tree and I think there
were a couple I was not CC'ed on. I'll coordinate with you because I'm
still seeing a couple of these warnings on other modules in the test
build.
Also I want to double check all the descriptions before I send for 6.11.
Jeff is it ok if I alter the text? I know you mentioned to Jonathan you
really just wanted to see the errors go away.
Ira
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/nvdimm/btt.c | 1 +
> drivers/nvdimm/core.c | 1 +
> drivers/nvdimm/e820.c | 1 +
> drivers/nvdimm/nd_virtio.c | 1 +
> drivers/nvdimm/of_pmem.c | 1 +
> drivers/nvdimm/pmem.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index 1e5aedaf8c7b..a47acc5d05df 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1721,6 +1721,7 @@ static void __exit nd_btt_exit(void)
>
> MODULE_ALIAS_ND_DEVICE(ND_DEVICE_BTT);
> MODULE_AUTHOR("Vishal Verma <vishal.l.verma@linux.intel.com>");
> +MODULE_DESCRIPTION("NVDIMM Block Translation Table");
> MODULE_LICENSE("GPL v2");
> module_init(nd_btt_init);
> module_exit(nd_btt_exit);
> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c
> index 2023a661bbb0..f4b6fb4b9828 100644
> --- a/drivers/nvdimm/core.c
> +++ b/drivers/nvdimm/core.c
> @@ -540,6 +540,7 @@ static __exit void libnvdimm_exit(void)
> nvdimm_devs_exit();
> }
>
> +MODULE_DESCRIPTION("NVDIMM (Non-Volatile Memory Device) core module");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Intel Corporation");
> subsys_initcall(libnvdimm_init);
> diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c
> index 4cd18be9d0e9..008b9aae74ff 100644
> --- a/drivers/nvdimm/e820.c
> +++ b/drivers/nvdimm/e820.c
> @@ -69,5 +69,6 @@ static struct platform_driver e820_pmem_driver = {
> module_platform_driver(e820_pmem_driver);
>
> MODULE_ALIAS("platform:e820_pmem*");
> +MODULE_DESCRIPTION("NVDIMM support for e820 type-12 memory");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Intel Corporation");
> diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
> index 1f8c667c6f1e..35c8fbbba10e 100644
> --- a/drivers/nvdimm/nd_virtio.c
> +++ b/drivers/nvdimm/nd_virtio.c
> @@ -123,4 +123,5 @@ int async_pmem_flush(struct nd_region *nd_region, struct bio *bio)
> return 0;
> };
> EXPORT_SYMBOL_GPL(async_pmem_flush);
> +MODULE_DESCRIPTION("Virtio Persistent Memory Driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index d3fca0ab6290..5134a8d08bf9 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -111,5 +111,6 @@ static struct platform_driver of_pmem_region_driver = {
>
> module_platform_driver(of_pmem_region_driver);
> MODULE_DEVICE_TABLE(of, of_pmem_region_match);
> +MODULE_DESCRIPTION("NVDIMM Device Tree support");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("IBM Corporation");
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 598fe2e89bda..57cb30f8a3b8 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -768,4 +768,5 @@ static struct nd_device_driver nd_pmem_driver = {
> module_nd_driver(nd_pmem_driver);
>
> MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>");
> +MODULE_DESCRIPTION("NVDIMM Persistent Memory Driver");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 416ff45264d50a983c3c0b99f0da6ee59f9acd68
> change-id: 20240526-md-drivers-nvdimm-121215a4b93f
> --
> Jeff Johnson <quic_jjohnson@quicinc.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
2024-06-10 13:58 ` Ira Weiny
@ 2024-06-10 14:03 ` Jeff Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-06-10 14:03 UTC (permalink / raw)
To: Ira Weiny, Vishal Verma, Dan Williams, Dave Jiang, Pankaj Gupta,
Oliver O'Halloran
Cc: nvdimm, linux-kernel, virtualization, kernel-janitors
On 6/10/2024 6:58 AM, Ira Weiny wrote:
> Jeff Johnson wrote:
>> Fix the 'make W=1' warnings:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
>
> Just to double check. This is a resend of this patch?
>
> https://lore.kernel.org/all/20240526-md-drivers-nvdimm-v1-1-172e682e76bd@quicinc.com/
>
> Dave Jiang, I'm picking up all these for the nvdimm tree and I think there
> were a couple I was not CC'ed on. I'll coordinate with you because I'm
> still seeing a couple of these warnings on other modules in the test
> build.
>
> Also I want to double check all the descriptions before I send for 6.11.
>
> Jeff is it ok if I alter the text? I know you mentioned to Jonathan you
> really just wanted to see the errors go away.
Yes, please make the text whatever makes the most sense. In most of these
cases I'm not a domain expert so I construct these descriptions based upon
code comments, Kconfig descriptions, and git descriptions, and in some cases
these are originally wrong due to cut-n-paste or the drivers have evolved so
that information is no longer accurate.
I need to add a version of that to my b4 cover letter!
/jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-10 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-26 17:07 [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-06 16:12 ` Dave Jiang
2024-06-10 13:58 ` Ira Weiny
2024-06-10 14:03 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®