mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bot+bpf-ci@kernel.org
To: tasos.papagiannnis@gmail.com,linux-security-module@vger.kernel.org
Cc: bpf@vger.kernel.org,linux-kernel@vger.kernel.org,linux-fsdevel@vger.kernel.org,paul@paul-moore.com,jmorris@namei.org,serge@hallyn.com,brauner@kernel.org,viro@zeniv.linux.org.uk,jack@suse.cz,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,kpsingh@kernel.org,matt@bobrowski.net,eddyz87@gmail.com,tasos.papagiannnis@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [RFC PATCH 1/2] security: Add hook for unresolved pathname opens
Date: Fri, 20 Nov 2026 10:44:33 +0000 (UTC)	[thread overview]
Message-ID: <0df319dfcd7e3797886c1bfa092cc986e1caf8922450cea44d8c4a38ec6d8adf@mail.kernel.org> (raw)
In-Reply-To: <20261120094820.11929-2-tasos.papagiannnis@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

> security: Add hook for unresolved pathname opens

TL;DR: Commit message only: it lists what the new file_open_name LSM hook
changes but not why it is needed, what existing hooks can't enforce, or which
LSM will use it.

> security: Add hook for unresolved pathname opens
>
> Check the copied pathname against the selected base before traversal or
> file changes, including O_PATH and O_TMPFILE.
> Pass lookup flags so policy can request a referenced retry. Recheck the
> base after each restart and cover kernel opens with an explicit root.
>
> Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>

This isn't a bug, but could the changelog say why a pre-lookup pathname hook
is needed, meaning what security_file_open(), security_inode_permission() and
the path hooks cannot enforce, and which LSM is expected to use it?

Each sentence currently lists what the patch changes (the call in
path_init(), the lookup_flags argument, the recheck on each path_openat()
retry, the ND_ROOT_PRESET case), but the problem being solved is not stated.


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44717653250

  reply	other threads:[~2026-11-20 10:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  9:48 [RFC PATCH 0/2] security: Add pre-lookup pathname open check Anastasios Papagiannis
2026-11-20  9:48 ` [RFC PATCH 1/2] security: Add hook for unresolved pathname opens Anastasios Papagiannis
2026-11-20 10:44   ` bot+bpf-ci [this message]
2026-11-20  9:48 ` [RFC PATCH 2/2] selftests/bpf: Test pathname open enforcement Anastasios Papagiannis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0df319dfcd7e3797886c1bfa092cc986e1caf8922450cea44d8c4a38ec6d8adf@mail.kernel.org \
    --to=bot+bpf-ci@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jack@suse.cz \
    --cc=jmorris@namei.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=mason@kernel.org \
    --cc=matt@bobrowski.net \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=tasos.papagiannnis@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®