From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Dongjin Kim <tobetter@gmail.com>
Subject: Re: [PATCH v2 02/13] arm64: dts: rockchip: Add Hardkernel ODROID-M1 board
Date: Wed, 28 Sep 2022 09:34:04 +0200 [thread overview]
Message-ID: <0e53c7c8-e04c-5a87-9703-02748b64e491@linaro.org> (raw)
In-Reply-To: <20220926183727.1893566-3-aurelien@aurel32.net>
On 26/09/2022 20:37, Aurelien Jarno wrote:
> From: Dongjin Kim <tobetter@gmail.com>
>
> This patch is to add a device tree for new board Hardkernel ODROID-M1
> based on Rockchip RK3568, includes basic peripherals -
> uart/eMMC/uSD/i2c and on-board ethernet.
Thank you for your patch. There is something to discuss/improve.
>
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> [aurelien@aurel32.net: addressed issues from initial review]
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3568-odroid-m1.dts | 414 ++++++++++++++++++
> 2 files changed, 415 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index ef79a672804a..12e2ef73fe80 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -66,3 +66,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
Mismatched order.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-28 7:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 18:37 [PATCH v2 00/13] Add support for the " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 01/13] dt-bindings: rockchip: Add " Aurelien Jarno
2022-09-28 7:33 ` Krzysztof Kozlowski
2022-09-28 7:34 ` Krzysztof Kozlowski
2022-09-26 18:37 ` [PATCH v2 02/13] arm64: dts: " Aurelien Jarno
2022-09-28 7:34 ` Krzysztof Kozlowski [this message]
2022-09-26 18:37 ` [PATCH v2 03/13] arm64: dts: rockchip: add thermal support to ODROID-M1 Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 04/13] arm64: dts: rockchip: Add NOR flash " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 05/13] arm64: dts: rockchip: Add analog audio on ODROID-M1 Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 06/13] arm64: dts: rockchip: Enable vop2 and hdmi tx " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 07/13] arm64: dts: rockchip: Enable HDMI audio " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 08/13] arm64: dts: rockchip: Enable the GPU " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 09/13] arm64: dts: rockchip: Enable the USB 2.0 ports " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 10/13] arm64: dts: rockchip: Enable the USB 3.0 " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 11/13] arm64: dts: rockchip: Add SATA support to ODROID-M1 Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 12/13] arm64: dts: rockchip: Add PCIEe v3 nodes " Aurelien Jarno
2022-09-26 18:37 ` [PATCH v2 13/13] arm64: dts: rockchip: Add IR receiver node " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e53c7c8-e04c-5a87-9703-02748b64e491@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aurelien@aurel32.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®