mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alessio Belle <Alessio.Belle@imgtec.com>
To: Brajesh Gupta <Brajesh.Gupta@imgtec.com>
Cc: Luigi Santivetti <Luigi.Santivetti@imgtec.com>,
	"imagination@lists.freedesktop.org"
	<imagination@lists.freedesktop.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"simona@ffwll.ch" <simona@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Frank Binns <Frank.Binns@imgtec.com>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>
Subject: Re: [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout
Date: Thu, 30 Jul 2026 08:19:47 +0000	[thread overview]
Message-ID: <0e6f71776667f6a36fc7a7482c985e9e044051ae.camel@imgtec.com> (raw)
In-Reply-To: <20260729-sched_timeout-v1-1-4adc801b1997@imgtec.com>

On Wed, 2026-07-29 at 09:49 +0530, Brajesh Gupta wrote:
> Firmware schedule workloads on the GPU and tracks progress.
> It is also responsible for detecting any lockup and triggering recovery.
> 
> Update the GPU scheduler timeout to a resonalbly high value to avoid

nit: resonalbly -> reasonably (will fix when applying this)

> premature timeout at the GPU scheduler end.
> 
> Signed-off-by: Brajesh Gupta <brajesh.gupta@imgtec.com>

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>

Thanks,
Alessio

> ---
>  drivers/gpu/drm/imagination/pvr_queue.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c
> index 54e88b4208d7..09993e858df8 100644
> --- a/drivers/gpu/drm/imagination/pvr_queue.c
> +++ b/drivers/gpu/drm/imagination/pvr_queue.c
> @@ -17,6 +17,7 @@
>  #include "pvr_rogue_fwif_client.h"
>  
>  #define MAX_DEADLINE_MS 30000
> +#define SCHED_TIMEOUT_PERIOD (2 * MAX_DEADLINE_MS)
>  
>  #define CTX_COMPUTE_CCCB_SIZE_LOG2 15
>  #define CTX_FRAG_CCCB_SIZE_LOG2 15
> @@ -1283,7 +1284,7 @@ struct pvr_queue *pvr_queue_create(struct pvr_context *ctx,
>  		.submit_wq = pvr_dev->sched_wq,
>  		.credit_limit = 64 * 1024,
>  		.hang_limit = 1,
> -		.timeout = msecs_to_jiffies(500),
> +		.timeout = msecs_to_jiffies(SCHED_TIMEOUT_PERIOD),
>  		.timeout_wq = pvr_dev->sched_wq,
>  		.name = "pvr-queue",
>  		.dev = pvr_dev->base.dev,
> 
> ---
> base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
> change-id: 20260729-sched_timeout-c981f354e853
> 
> Best regards,


  reply	other threads:[~2026-07-30  8:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  4:19 Brajesh Gupta
2026-07-30  8:19 ` Alessio Belle [this message]
2026-07-31  8:30 ` Alessio Belle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e6f71776667f6a36fc7a7482c985e9e044051ae.camel@imgtec.com \
    --to=alessio.belle@imgtec.com \
    --cc=Brajesh.Gupta@imgtec.com \
    --cc=Frank.Binns@imgtec.com \
    --cc=Luigi.Santivetti@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imagination@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®