mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout
@ 2026-07-29  4:19 Brajesh Gupta
  2026-07-30  8:19 ` Alessio Belle
  2026-07-31  8:30 ` Alessio Belle
  0 siblings, 2 replies; 3+ messages in thread
From: Brajesh Gupta @ 2026-07-29  4:19 UTC (permalink / raw)
  To: Alessio Belle, Luigi Santivetti, Frank Binns, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: imagination, dri-devel, linux-kernel, Brajesh Gupta

Firmware schedule workloads on the GPU and tracks progress.
It is also responsible for detecting any lockup and triggering recovery.

Update the GPU scheduler timeout to a resonalbly high value to avoid
premature timeout at the GPU scheduler end.

Signed-off-by: Brajesh Gupta <brajesh.gupta@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_queue.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c
index 54e88b4208d7..09993e858df8 100644
--- a/drivers/gpu/drm/imagination/pvr_queue.c
+++ b/drivers/gpu/drm/imagination/pvr_queue.c
@@ -17,6 +17,7 @@
 #include "pvr_rogue_fwif_client.h"
 
 #define MAX_DEADLINE_MS 30000
+#define SCHED_TIMEOUT_PERIOD (2 * MAX_DEADLINE_MS)
 
 #define CTX_COMPUTE_CCCB_SIZE_LOG2 15
 #define CTX_FRAG_CCCB_SIZE_LOG2 15
@@ -1283,7 +1284,7 @@ struct pvr_queue *pvr_queue_create(struct pvr_context *ctx,
 		.submit_wq = pvr_dev->sched_wq,
 		.credit_limit = 64 * 1024,
 		.hang_limit = 1,
-		.timeout = msecs_to_jiffies(500),
+		.timeout = msecs_to_jiffies(SCHED_TIMEOUT_PERIOD),
 		.timeout_wq = pvr_dev->sched_wq,
 		.name = "pvr-queue",
 		.dev = pvr_dev->base.dev,

---
base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
change-id: 20260729-sched_timeout-c981f354e853

Best regards,
-- 
Brajesh Gupta <brajesh.gupta@imgtec.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout
  2026-07-29  4:19 [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout Brajesh Gupta
@ 2026-07-30  8:19 ` Alessio Belle
  2026-07-31  8:30 ` Alessio Belle
  1 sibling, 0 replies; 3+ messages in thread
From: Alessio Belle @ 2026-07-30  8:19 UTC (permalink / raw)
  To: Brajesh Gupta
  Cc: Luigi Santivetti, imagination, tzimmermann, simona, dri-devel,
	linux-kernel, Frank Binns, maarten.lankhorst, mripard, airlied

On Wed, 2026-07-29 at 09:49 +0530, Brajesh Gupta wrote:
> Firmware schedule workloads on the GPU and tracks progress.
> It is also responsible for detecting any lockup and triggering recovery.
> 
> Update the GPU scheduler timeout to a resonalbly high value to avoid

nit: resonalbly -> reasonably (will fix when applying this)

> premature timeout at the GPU scheduler end.
> 
> Signed-off-by: Brajesh Gupta <brajesh.gupta@imgtec.com>

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>

Thanks,
Alessio

> ---
>  drivers/gpu/drm/imagination/pvr_queue.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c
> index 54e88b4208d7..09993e858df8 100644
> --- a/drivers/gpu/drm/imagination/pvr_queue.c
> +++ b/drivers/gpu/drm/imagination/pvr_queue.c
> @@ -17,6 +17,7 @@
>  #include "pvr_rogue_fwif_client.h"
>  
>  #define MAX_DEADLINE_MS 30000
> +#define SCHED_TIMEOUT_PERIOD (2 * MAX_DEADLINE_MS)
>  
>  #define CTX_COMPUTE_CCCB_SIZE_LOG2 15
>  #define CTX_FRAG_CCCB_SIZE_LOG2 15
> @@ -1283,7 +1284,7 @@ struct pvr_queue *pvr_queue_create(struct pvr_context *ctx,
>  		.submit_wq = pvr_dev->sched_wq,
>  		.credit_limit = 64 * 1024,
>  		.hang_limit = 1,
> -		.timeout = msecs_to_jiffies(500),
> +		.timeout = msecs_to_jiffies(SCHED_TIMEOUT_PERIOD),
>  		.timeout_wq = pvr_dev->sched_wq,
>  		.name = "pvr-queue",
>  		.dev = pvr_dev->base.dev,
> 
> ---
> base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
> change-id: 20260729-sched_timeout-c981f354e853
> 
> Best regards,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout
  2026-07-29  4:19 [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout Brajesh Gupta
  2026-07-30  8:19 ` Alessio Belle
@ 2026-07-31  8:30 ` Alessio Belle
  1 sibling, 0 replies; 3+ messages in thread
From: Alessio Belle @ 2026-07-31  8:30 UTC (permalink / raw)
  To: Luigi Santivetti, Frank Binns, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, Brajesh Gupta
  Cc: imagination, dri-devel, linux-kernel

On Wed, 29 Jul 2026 09:49:08 +0530, Brajesh Gupta wrote:
> Firmware schedule workloads on the GPU and tracks progress.
> It is also responsible for detecting any lockup and triggering recovery.
> 
> Update the GPU scheduler timeout to a resonalbly high value to avoid
> premature timeout at the GPU scheduler end.
> 
> 
> [...]

Applied to drm-misc-next, thanks!

[1/1] drm/imagination: Set scheduler timeout period higher than Firmware timeout
      commit: 2224d6642136767ec01d146d48ffc881b55b32f7

Best regards,
-- 
Alessio Belle <alessio.belle@imgtec.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-31  8:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-29  4:19 [PATCH] drm/imagination: Set scheduler timeout period higher than Firmware timeout Brajesh Gupta
2026-07-30  8:19 ` Alessio Belle
2026-07-31  8:30 ` Alessio Belle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®