From: John Garry <john.g.garry@oracle.com>
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, bvanassche@acm.org,
linux-kernel@vger.kernel.org, dgilbert@interlog.com
Subject: Re: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q
Date: Wed, 22 Mar 2023 13:36:16 +0000 [thread overview]
Message-ID: <0e7b4269-a96d-db71-b0a6-5e61af731fc2@oracle.com> (raw)
In-Reply-To: <92a2d9c4-cc7a-6a26-07ea-b49ecdc920cc@oracle.com>
On 20/03/2023 11:41, John Garry wrote:
>> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out
>> command) [failed]
>> runtime ... 1.467s
>> --- tests/scsi/004.out 2023-02-28 16:52:49.000000000 +0000
>> +++ /lkp/benchmarks/blktests/results/nodev/scsi/004.out.bad
>> 2023-03-18 00:19:00.232079954 +0000
>> @@ -1,3 +1,2 @@
>> Running scsi/004
>> -Input/output error
>> Test complete
>>
>
> I'll check this now.
This should fix it:
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -5580,7 +5580,7 @@ static int schedule_resp(struct scsi_cmnd *cmnd,
struct sdebug_dev_info *devip,
int num_in_q = scsi_device_busy(sdp);
int qdepth = cmnd->device->queue_depth;
- if ((num_in_q == (qdepth - 1)) &&
+ if ((num_in_q == qdepth) &&
(atomic_inc_return(&sdebug_a_tsf) >=
I'll send that change in my other scsi_debug series after I test further.
next prev parent reply other threads:[~2023-03-22 13:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 9:31 [PATCH RESEND v2 00/11] scsi_debug: Some minor improvements John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 01/11] scsi: scsi_debug: Don't hold driver host struct pointer in host->hostdata[] John Garry
2023-03-14 2:34 ` Douglas Gilbert
2023-03-16 8:48 ` John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 02/11] scsi: scsi_debug: Stop setting devip->sdbg_host twice John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 03/11] scsi: scsi_debug: Drop scsi_debug_abort() NULL pointer checks John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 04/11] scsi: scsi_debug: Drop scsi_debug_device_reset() " John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 05/11] scsi: scsi_debug: Drop scsi_debug_target_reset() " John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 06/11] scsi: scsi_debug: Drop scsi_debug_bus_reset() " John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 07/11] scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer check John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 08/11] scsi: scsi_debug: Drop check for num_in_q exceeding queue depth John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop sdebug_dev_info.num_in_q John Garry
2023-03-20 5:31 ` kernel test robot
2023-03-20 11:41 ` John Garry
2023-03-22 13:36 ` John Garry [this message]
2023-03-13 9:31 ` [PATCH RESEND v2 10/11] scsi: scsi_debug: Get command abort feature working again John Garry
2023-03-13 9:31 ` [PATCH RESEND v2 11/11] scsi: scsi_debug: Add poll mode deferred completions to statistics John Garry
2023-03-17 3:27 ` [PATCH RESEND v2 00/11] scsi_debug: Some minor improvements Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e7b4269-a96d-db71-b0a6-5e61af731fc2@oracle.com \
--to=john.g.garry@oracle.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®