Re: [PATCH RESEND v2 01/11] scsi: scsi_debug: Don't hold driver host struct pointer in host->hostdata[]

[John Garry <john.g.garry@oracle.com>]

On 14/03/2023 02:34, Douglas Gilbert wrote:
> 2023-03-13 05:31, John Garry wrote:
>> This driver stores just a pointer to the driver host structure in
>> host->hostdata[]. Most other drivers actually have the driver host
>> structure allocated in host->hostdata[], but this driver is different as
>> we allocate that memory separately before allocating the shost memory.
>>
>> However there is no need to allocate this memory only in host->hostdata[]
>> when we can already look up the driver host structure from 
>> shost->dma_dev,
>> so add a macro for this - shost_to_sdebug_host(). Rename to_sdebug_host()
>> -> dev_to_sdebug_host() to avoid ambiguity.
>>
>> Also remove a check for !sdbg_host in find_build_dev_info(), as this 
>> cannot
>> be true. Other similar checks will be later removed.
>>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
> Acked-by: Douglas Gilbert <dgilbert@interlog.com>
> 
> Please apply my "ack" to the rest of this series (2 through 11).
> 

Thanks.

Hi Martin, Please let me know if you would like me to send the series 
again with Doug's tags appended.

> Good the have other eyes looking at this driver and making
> improvements.

No worries, Please check the other series which I sent when you can. I 
am not sure how to solve the issue related to the last patch there. 
Maybe a solution would be to just remove all the shosts and then re-add 
with updated can_queue.

John