From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Dale Whinham <daleyo@gmail.com>
Cc: "Rob Clark" <robin.clark@oss.qualcomm.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Abhinav Kumar" <abhinav.kumar@linux.dev>,
"Jessica Zhang" <jesszhan0024@gmail.com>,
"Sean Paul" <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Jérôme de Bretagne" <jerome.debretagne@gmail.com>,
"Steev Klimaszewski" <threeway@gmail.com>
Subject: Re: [PATCH] drm/msm/dp: Enable support for eDP v1.4+ link rates table
Date: Tue, 16 Dec 2025 16:32:44 +0200 [thread overview]
Message-ID: <0e9c0f8d-c1f6-4c84-b467-37e11837882e@oss.qualcomm.com> (raw)
In-Reply-To: <2c1656ff-cba9-4122-a414-d22958f5857b@gmail.com>
On 16/12/2025 16:31, Dale Whinham wrote:
> On 15/12/2025 22:15, Dmitry Baryshkov wrote:
>> I'd suggest following i915 and writing DP_LANE_COUNT_SET before
>> DP_LINK_BW_SET.
>
> Thank you - made this change for v2.
>
>>> + /* For eDP v1.4+, parse the SUPPORTED_LINK_RATES table */
>>> + if (link_info->revision >= DP_DPCD_REV_14) {
>>
>> No, eDP has separate versioning register. DP revision != eDP revision.
>
> You're absolutely right, this was a mistake.
> Does something like this seem reasonable for v2?
Yes.
>
> if (msm_dp_panel->dpcd[DP_EDP_CONFIGURATION_CAP]) {
> u8 edp_rev;
>
> rc = drm_dp_dpcd_read_byte(panel->aux, DP_EDP_DPCD_REV, &edp_rev);
> if (rc)
> return rc;
>
> if (edp_rev >= DP_EDP_14) {
> // parse the rates
> // ...
> }
> }
--
With best wishes
Dmitry
prev parent reply other threads:[~2025-12-16 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 20:48 Dale Whinham
2025-12-15 22:15 ` Dmitry Baryshkov
2025-12-16 14:31 ` Dale Whinham
2025-12-16 14:32 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e9c0f8d-c1f6-4c84-b467-37e11837882e@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=daleyo@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jerome.debretagne@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=threeway@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®