* [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe()
@ 2018-02-11 21:04 SF Markus Elfring
2018-02-13 18:45 ` Andy Shevchenko
2018-02-22 14:29 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2018-02-11 21:04 UTC (permalink / raw)
To: linux-gpio, David Cohen, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 11 Feb 2018 21:56:42 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpio/gpio-intel-mid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
index 629575ea46a0..028d64c2cb1e 100644
--- a/drivers/gpio/gpio-intel-mid.c
+++ b/drivers/gpio/gpio-intel-mid.c
@@ -361,10 +361,8 @@ static int intel_gpio_probe(struct pci_dev *pdev,
pcim_iounmap_regions(pdev, 1 << 1);
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "can't allocate chip data\n");
+ if (!priv)
return -ENOMEM;
- }
priv->reg_base = pcim_iomap_table(pdev)[0];
priv->chip.label = dev_name(&pdev->dev);
--
2.16.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe()
2018-02-11 21:04 [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe() SF Markus Elfring
@ 2018-02-13 18:45 ` Andy Shevchenko
2018-02-22 14:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-02-13 18:45 UTC (permalink / raw)
To: SF Markus Elfring
Cc: open list:GPIO SUBSYSTEM, David Cohen, Linus Walleij, LKML,
kernel-janitors
On Sun, Feb 11, 2018 at 11:04 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 11 Feb 2018 21:56:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
Linus, same comment as previously.
If you are OK with the change, take my
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/gpio/gpio-intel-mid.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
> index 629575ea46a0..028d64c2cb1e 100644
> --- a/drivers/gpio/gpio-intel-mid.c
> +++ b/drivers/gpio/gpio-intel-mid.c
> @@ -361,10 +361,8 @@ static int intel_gpio_probe(struct pci_dev *pdev,
> pcim_iounmap_regions(pdev, 1 << 1);
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv) {
> - dev_err(&pdev->dev, "can't allocate chip data\n");
> + if (!priv)
> return -ENOMEM;
> - }
>
> priv->reg_base = pcim_iomap_table(pdev)[0];
> priv->chip.label = dev_name(&pdev->dev);
> --
> 2.16.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe()
2018-02-11 21:04 [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe() SF Markus Elfring
2018-02-13 18:45 ` Andy Shevchenko
@ 2018-02-22 14:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-02-22 14:29 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, David Cohen, LKML, kernel-janitors
On Sun, Feb 11, 2018 at 10:04 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 11 Feb 2018 21:56:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-22 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-11 21:04 [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe() SF Markus Elfring
2018-02-13 18:45 ` Andy Shevchenko
2018-02-22 14:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome