* [PATCH] x86, msr/cpuid: Cocci spatch "ptr_ret.spatch"
@ 2013-06-01 9:58 Thomas Meyer
2013-06-01 14:49 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2013-06-01 9:58 UTC (permalink / raw)
To: hpa, tglx, mingo, x86, linux-kernel
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c
--- a/arch/x86/kernel/cpuid.c
+++ b/arch/x86/kernel/cpuid.c
@@ -143,7 +143,7 @@ static __cpuinit int cpuid_device_create
dev = device_create(cpuid_class, NULL, MKDEV(CPUID_MAJOR, cpu), NULL,
"cpu%d", cpu);
- return IS_ERR(dev) ? PTR_ERR(dev) : 0;
+ return PTR_RET(dev);
}
static void cpuid_device_destroy(int cpu)
diff -u -p a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -206,7 +206,7 @@ static int __cpuinit msr_device_create(i
dev = device_create(msr_class, NULL, MKDEV(MSR_MAJOR, cpu), NULL,
"msr%d", cpu);
- return IS_ERR(dev) ? PTR_ERR(dev) : 0;
+ return PTR_RET(dev);
}
static void msr_device_destroy(int cpu)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86, msr/cpuid: Cocci spatch "ptr_ret.spatch"
2013-06-01 9:58 [PATCH] x86, msr/cpuid: Cocci spatch "ptr_ret.spatch" Thomas Meyer
@ 2013-06-01 14:49 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2013-06-01 14:49 UTC (permalink / raw)
To: Thomas Meyer, tglx, mingo, x86, linux-kernel
This is not an acceptable patch... no description of any kind and a subject line which would only make sense if the cocci scripts are checked into the kernel tree.
Thomas Meyer <thomas@m3y3r.de> wrote:
>
>Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>---
>
>diff -u -p a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c
>--- a/arch/x86/kernel/cpuid.c
>+++ b/arch/x86/kernel/cpuid.c
>@@ -143,7 +143,7 @@ static __cpuinit int cpuid_device_create
>
> dev = device_create(cpuid_class, NULL, MKDEV(CPUID_MAJOR, cpu), NULL,
> "cpu%d", cpu);
>- return IS_ERR(dev) ? PTR_ERR(dev) : 0;
>+ return PTR_RET(dev);
> }
>
> static void cpuid_device_destroy(int cpu)
>diff -u -p a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
>--- a/arch/x86/kernel/msr.c
>+++ b/arch/x86/kernel/msr.c
>@@ -206,7 +206,7 @@ static int __cpuinit msr_device_create(i
>
> dev = device_create(msr_class, NULL, MKDEV(MSR_MAJOR, cpu), NULL,
> "msr%d", cpu);
>- return IS_ERR(dev) ? PTR_ERR(dev) : 0;
>+ return PTR_RET(dev);
> }
>
> static void msr_device_destroy(int cpu)
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-01 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-01 9:58 [PATCH] x86, msr/cpuid: Cocci spatch "ptr_ret.spatch" Thomas Meyer
2013-06-01 14:49 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome