From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] debugobjects: Reduce contention on pool lock in fill_pool()
Date: Thu, 10 Oct 2024 11:33:41 +0800 [thread overview]
Message-ID: <0f108181-13dc-c992-6596-bcafd2b3e000@huawei.com> (raw)
In-Reply-To: <87r08st3ey.ffs@tglx>
On 2024/10/7 22:04, Thomas Gleixner wrote:
> On Wed, Sep 11 2024 at 16:35, Zhen Lei wrote:
>> + /*
>> + * Avoid allocation and lock contention when another CPU is already
>> + * in the allocation path.
>> + */
>> + if (atomic_read(&cpus_allocating))
>> + return;
>
> Hmm. I really don't want to rely on a single CPU doing allocations in
> case that the pool level reached a critical state. That CPU might be
> scheduled out and all others are consuming objects up to the point where
> the pool becomes empty.
That makes sense, you're thoughtful.
>
> Let me integrate this into the series I'm going to post soon.
>
> Thanks,
>
> tglx
> .
>
--
Regards,
Zhen Lei
prev parent reply other threads:[~2024-10-10 3:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 8:35 [PATCH v3 0/3] debugobjects: Do some minor optimizations, fixes and cleaups Zhen Lei
2024-09-11 8:35 ` [PATCH v3 1/3] debugobjects: Delete a piece of redundant code Zhen Lei
2024-10-15 15:36 ` [tip: core/debugobjects] " tip-bot2 for Zhen Lei
2024-09-11 8:35 ` [PATCH v3 2/3] debugobjects: Use hlist_splice_init() to reduce lock conflicts Zhen Lei
2024-10-15 15:36 ` [tip: core/debugobjects] debugobjects: Collect newly allocated objects in a list to reduce lock contention tip-bot2 for Zhen Lei
2024-09-11 8:35 ` [PATCH v3 3/3] debugobjects: Reduce contention on pool lock in fill_pool() Zhen Lei
2024-09-11 9:04 ` Leizhen (ThunderTown)
2024-09-17 12:19 ` Thomas Gleixner
2024-09-25 2:03 ` Leizhen (ThunderTown)
2024-10-07 14:04 ` Thomas Gleixner
2024-10-10 3:33 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f108181-13dc-c992-6596-bcafd2b3e000@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®