mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v3 1/3] debugobjects: Delete a piece of redundant code
Date: Wed, 11 Sep 2024 16:35:19 +0800	[thread overview]
Message-ID: <20240911083521.2257-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20240911083521.2257-1-thunder.leizhen@huawei.com>

The statically allocated objects are all located in obj_static_pool[],
the whole memory of obj_static_pool[] will be reclaimed later. Therefore,
there is no need to split the remaining statically nodes in list obj_pool
into isolated ones, no one will use them anymore. Just write
INIT_HLIST_HEAD(&obj_pool) is enough. Since hlist_move_list() directly
discards the old list, even this can be omitted.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 lib/debugobjects.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 5ce473ad499bad3..df48acc5d4b34fc 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1325,10 +1325,10 @@ static int __init debug_objects_replace_static_objects(void)
 	 * active object references.
 	 */
 
-	/* Remove the statically allocated objects from the pool */
-	hlist_for_each_entry_safe(obj, tmp, &obj_pool, node)
-		hlist_del(&obj->node);
-	/* Move the allocated objects to the pool */
+	/*
+	 * Replace the statically allocated objects list with the allocated
+	 * objects list.
+	 */
 	hlist_move_list(&objects, &obj_pool);
 
 	/* Replace the active object references */
-- 
2.34.1


  reply	other threads:[~2024-09-11  8:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  8:35 [PATCH v3 0/3] debugobjects: Do some minor optimizations, fixes and cleaups Zhen Lei
2024-09-11  8:35 ` Zhen Lei [this message]
2024-10-15 15:36   ` [tip: core/debugobjects] debugobjects: Delete a piece of redundant code tip-bot2 for Zhen Lei
2024-09-11  8:35 ` [PATCH v3 2/3] debugobjects: Use hlist_splice_init() to reduce lock conflicts Zhen Lei
2024-10-15 15:36   ` [tip: core/debugobjects] debugobjects: Collect newly allocated objects in a list to reduce lock contention tip-bot2 for Zhen Lei
2024-09-11  8:35 ` [PATCH v3 3/3] debugobjects: Reduce contention on pool lock in fill_pool() Zhen Lei
2024-09-11  9:04   ` Leizhen (ThunderTown)
2024-09-17 12:19     ` Thomas Gleixner
2024-09-25  2:03       ` Leizhen (ThunderTown)
2024-10-07 14:04   ` Thomas Gleixner
2024-10-10  3:33     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240911083521.2257-2-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®