From: Guenter Roeck <linux@roeck-us.net>
To: Brian Norris <briannorris@chromium.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Pavel Machek <pavel@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-pm@vger.kernel.org, Julia Lawall <Julia.Lawall@inria.fr>,
linux-kernel@vger.kernel.org, cocci@inria.fr
Subject: Re: [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier() return code
Date: Tue, 2 Dec 2025 19:34:07 -0800 [thread overview]
Message-ID: <0f729108-6928-4644-b02a-fa7020cdffc4@roeck-us.net> (raw)
In-Reply-To: <20251202193129.1411419-1-briannorris@chromium.org>
On Tue, Dec 02, 2025 at 11:30:24AM -0800, Brian Norris wrote:
> Apparently this test is the only code that checks the return code from
> pm_runtime_barrier(), and it turns out that's for good reason -- it's
> inherently racy, and a bad idea. We're going to make
> pm_runtime_barrier() return void, so prepare for that by dropping any
> return code checks.
>
> This resolves some test failures seen like the following:
>
> [ 34.559694] # pm_runtime_error_test: EXPECTATION FAILED at drivers/base/power/runtime-test.c:177
> [ 34.559694] Expected 1 == pm_runtime_barrier(dev), but
> [ 34.559694] pm_runtime_barrier(dev) == 0 (0x0)
> [ 34.563604] # pm_runtime_error_test: pass:0 fail:1 skip:0 total:1
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/lkml/93259f2b-7017-4096-a31b-cabbf6152e9b@roeck-us.net/
> Signed-off-by: Brian Norris <briannorris@chromium.org>
With this series on top of v6.18:
Qemu test results:
total: 610 pass: 610 fail: 0
Unit test results:
pass: 666898 fail: 0
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
next prev parent reply other threads:[~2025-12-03 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 19:30 Brian Norris
2025-12-02 19:30 ` [PATCH 2/3] PM: runtime: Make pm_runtime_barrier() return void Brian Norris
2025-12-03 3:34 ` Guenter Roeck
2025-12-02 19:30 ` [PATCH 3/3] coccinelle: Drop pm_runtime_barrier() error code checks Brian Norris
2025-12-03 3:34 ` Guenter Roeck
2025-12-03 3:34 ` Guenter Roeck [this message]
2025-12-04 19:41 ` [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier() return code Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f729108-6928-4644-b02a-fa7020cdffc4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Julia.Lawall@inria.fr \
--cc=briannorris@chromium.org \
--cc=cocci@inria.fr \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®