mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Zeng Heng <zengheng4@huawei.com>,
	linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Dan Carpenter <dan.carpenter@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Wei Li <liwei391@huawei.com>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	Xie XiuQi <xiexiuqi@huawei.com>
Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map()
Date: Mon, 15 Apr 2024 18:36:53 +0200	[thread overview]
Message-ID: <0f7821f8-63f2-4cf4-8865-1ae0aaf42897@web.de> (raw)
In-Reply-To: <20240415105328.3651441-1-zengheng4@huawei.com>

>                   … Because the pinctrl_dt_free_maps() includes the
> droping operation, here we call it directly.

I find this change description improvable.

* How do you think about to avoid a typo?

* Would another imperative wording be more desirable?

Regards,
Markus

  parent reply	other threads:[~2024-04-15 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 10:53 Zeng Heng
2024-04-15 11:08 ` Dan Carpenter
2024-04-15 16:36 ` Markus Elfring [this message]
2024-04-16 13:33 ` Linus Walleij
2024-04-17 15:30 ` Andy Shevchenko
2024-04-17 15:38   ` Dan Carpenter
2024-04-17 17:12     ` Andy Shevchenko
2024-04-17 17:49       ` Dan Carpenter
2024-04-18 10:05         ` Andy Shevchenko
2024-04-19 13:24         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f7821f8-63f2-4cf4-8865-1ae0aaf42897@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@linaro.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=weiyongjun1@huawei.com \
    --cc=xiexiuqi@huawei.com \
    --cc=zengheng4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®