From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zeng Heng <zengheng4@huawei.com>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
xiexiuqi@huawei.com, linux-gpio@vger.kernel.org,
weiyongjun1@huawei.com, liwei391@huawei.com
Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map()
Date: Mon, 15 Apr 2024 14:08:37 +0300 [thread overview]
Message-ID: <637f9185-3fde-48c4-9a47-30987c8dd5a2@moroto.mountain> (raw)
In-Reply-To: <20240415105328.3651441-1-zengheng4@huawei.com>
On Mon, Apr 15, 2024 at 06:53:28PM +0800, Zeng Heng wrote:
> If we fail to allocate propname buffer, we need to drop the reference
> count we just took. Because the pinctrl_dt_free_maps() includes the
> droping operation, here we call it directly.
>
> Fixes: 91d5c5060ee2 ("pinctrl: devicetree: fix null pointer dereferencing in pinctrl_dt_to_map")
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
> ---
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
next prev parent reply other threads:[~2024-04-15 11:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 10:53 Zeng Heng
2024-04-15 11:08 ` Dan Carpenter [this message]
2024-04-15 16:36 ` Markus Elfring
2024-04-16 13:33 ` Linus Walleij
2024-04-17 15:30 ` Andy Shevchenko
2024-04-17 15:38 ` Dan Carpenter
2024-04-17 17:12 ` Andy Shevchenko
2024-04-17 17:49 ` Dan Carpenter
2024-04-18 10:05 ` Andy Shevchenko
2024-04-19 13:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=637f9185-3fde-48c4-9a47-30987c8dd5a2@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiexiuqi@huawei.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®